Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Prevent disabling a parent template when children exist #36192

Merged

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Dec 3, 2021

Pull Request for Issue # .

Summary of Changes

To prevent a possible disaster (disabling a parent template but child still around and default) a simple check was added in the installer component. (FWIW if a parent is disabled the child template is fully functional for the Cassiopeia but if a template also disables some plugins, etc then it might break)

Testing Instructions

Actual result BEFORE applying this Pull Request

A parent template could be disabled although there might be children

Expected result AFTER applying this Pull Request

Disabling is not possible if children exist

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Dec 3, 2021
@khu5h1
Copy link
Contributor

khu5h1 commented Dec 4, 2021

I have tested this item ✅ successfully on f00ce49


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36192.

Co-authored-by: Phil E. Taylor <phil@phil-taylor.com>
@Quy
Copy link
Contributor

Quy commented Dec 5, 2021

I have tested this item ✅ successfully on 7f08205


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36192.

@Quy
Copy link
Contributor

Quy commented Dec 5, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36192.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 5, 2021
@bembelimen bembelimen merged commit 3e54177 into joomla:4.1-dev Dec 7, 2021
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 7, 2021
@bembelimen bembelimen added this to the Joomla 4.1 milestone Dec 7, 2021
@dgrammatiko dgrammatiko deleted the 4.1-dev—disable-parent-template branch December 7, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants