Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature branch/remove experiment tracking #2237

Merged
merged 17 commits into from
Feb 25, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove deprecation banner for ET
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Huong Nguyen committed Feb 20, 2025
commit 09516b886051118e9750dca535d4ab70fb8f8d4b
11 changes: 0 additions & 11 deletions cypress/support/commands.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Add any reusable custom commands here
import { join } from 'path';
import { localStorageETDeprecationBannerSeen } from '../../src/config';

/**
* Custom command for intercepting network requests for REST
@@ -102,16 +101,6 @@ Cypress.Commands.add('__validateImage__', (downloadedFilename) => {
});
});

/**
* Custom command to conditionally visit a page based on spec file path
*/
Cypress.Commands.add('__conditionalVisit__', () => {
cy.visit('/', {
onBeforeLoad(win) {
win.localStorage.setItem(localStorageETDeprecationBannerSeen, JSON.stringify(true));
}
});
});

/**
* Custom command to fill out and submit the hosting shareable URL form
2 changes: 1 addition & 1 deletion cypress/support/index.js
Original file line number Diff line number Diff line change
@@ -4,5 +4,5 @@ import './commands';

// Command to perform before each test case run
beforeEach(() => {
cy.__conditionalVisit__();
cy.visit('/');
});
4 changes: 4 additions & 0 deletions cypress/tests/ui/flowchart/shareable-urls.cy.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
describe('Shareable URLs with empty localStorage', () => {
beforeEach(() => {
// Clears localStorage before each test
cy.clearLocalStorage();
});

it('verifies that users can open the Deploy Kedro-Viz modal if the localStorage is empty. #TC-52', () => {
// Intercept the network request to mock with a fixture
7 changes: 1 addition & 6 deletions cypress/tests/ui/toolbar/global-toolbar.cy.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
// All E2E Tests Related to global-toolbar goes here.

import { prettifyName, stripNamespace } from '../../../../src/utils';
import { localStorageETDeprecationBannerSeen } from '../../../../src/config';

describe('Global Toolbar', () => {
before(() => {
cy.visit('/', {
onBeforeLoad(win) {
win.localStorage.setItem(localStorageETDeprecationBannerSeen, JSON.stringify(true));
}
});
cy.visit('/');
cy.enablePrettyNames(); // Enable pretty names using the custom command
});

96 changes: 0 additions & 96 deletions src/components/deprecation-banner/deprecation-banner.js

This file was deleted.

84 changes: 0 additions & 84 deletions src/components/deprecation-banner/deprecation-banner.scss

This file was deleted.

2 changes: 0 additions & 2 deletions src/components/wrapper/wrapper.js
Original file line number Diff line number Diff line change
@@ -10,7 +10,6 @@ import FlowChartWrapper from '../flowchart-wrapper';
import SettingsModal from '../settings-modal';
import UpdateReminder from '../update-reminder';
import ShareableUrlModal from '../shareable-url-modal';
import { DeprecationBanner } from '../deprecation-banner/deprecation-banner';

import './wrapper.scss';

@@ -58,7 +57,6 @@ export const Wrapper = ({ displayGlobalNavigation, theme }) => {
latestVersion={latestVersion}
/>
{isRunningLocally() ? <ShareableUrlModal /> : null}
<DeprecationBanner />
{version && (
<UpdateReminder isOutdated={isOutdated} version={version} />
)}
2 changes: 0 additions & 2 deletions src/config.js
Original file line number Diff line number Diff line change
@@ -4,8 +4,6 @@ export const localStorageMetricsSelect = 'KedroViz-metrics-chart-select';
export const localStorageShareableUrl = 'KedroViz-shareable-url';
export const localStorageFeedbackSeen = 'KedroViz-feedback-seen';
export const localStorageBannerStatus = 'KedroViz-banners';
export const localStorageETDeprecationBannerSeen =
'KedroViz-ET-deprecation-banner-seen';

export const linkToFlowchartInitialVal = {
fromURL: null,

Unchanged files with check annotations Beta

![Kedro-Viz data flow diagram](/.github/img/frontend-architecture.png)
Kedro-Viz currently utilizes one method of data ingestion: the Redux setup for the pipeline and flowchart-view related components.

Check warning on line 68 in ARCHITECTURE.md

GitHub Actions / vale

[vale] ARCHITECTURE.md#L68

[Kedro-viz.weaselwords] 'currently' is a weasel word!
Raw output
{"message": "[Kedro-viz.weaselwords] 'currently' is a weasel word!", "location": {"path": "ARCHITECTURE.md", "range": {"start": {"line": 68, "column": 11}}}, "severity": "WARNING"}
On initialisation for the Redux setup, Kedro-Viz [manually normalises pipeline data](/src/store/normalize-data.js), in order to [make immutable state updates as performant as possible](https://redux.js.org/recipes/structuring-reducers/normalizing-state-shape).
Type `kedro: Run Kedro Viz` and select the command.
This will launch Kedro-Viz and display your pipeline visually within the extension.
![Kedro Viz in VSCode](./images/viz-in-vscode.gif)

Check warning on line 328 in docs/source/kedro-viz_visualisation.md

GitHub Actions / vale

[vale] docs/source/kedro-viz_visualisation.md#L328

[Kedro-viz.Spellings] Did you really mean 'VSCode'?
Raw output
{"message": "[Kedro-viz.Spellings] Did you really mean 'VSCode'?", "location": {"path": "docs/source/kedro-viz_visualisation.md", "range": {"start": {"line": 328, "column": 16}}}, "severity": "WARNING"}
## Citation
If you're an academic, Kedro-Viz can also help you, for example, as a tool to visualise how your publication's pipeline is structured. Find our citation reference on [Zenodo](https://doi.org/10.5281/zenodo.4277218).

Check warning on line 282 in package/README.md

GitHub Actions / vale

[vale] package/README.md#L282

[Kedro-viz.Spellings] Did you really mean 'Zenodo'?
Raw output
{"message": "[Kedro-viz.Spellings] Did you really mean 'Zenodo'?", "location": {"path": "package/README.md", "range": {"start": {"line": 282, "column": 168}}}, "severity": "WARNING"}