Feature branch/remove experiment tracking #2237

Huongg · 2025-01-13T09:39:55Z

Description

fixes #2202.

This PR is specifically to QAing all changes related to the removal of ET from the Kedro-Viz codebase, including:

Remove ET front-end components #2207
Remove ET back-end components #2208
Get version using restAPI #2242
Remove ET - Update Documentation and References #2209
Remove deprecation banner for ET

For broader changes involving Kedro Framework and Kedro Starters, please refer to the parent ticket #2202.

🗳️ This change requires a vote from the TSC, please cast it by leaving a review or an approval review on the PR 🗳️

QA notes:

Checkout the branch and run it locally or via the Gitpod link. Everything should work fine with the Experiment Tracking not appearing on the page.
There should be no errors or failed tests.

Checklist

Read the contributing guidelines
Opened this PR as a 'Draft Pull Request' if it is work-in-progress
Updated the documentation to reflect the code changes
Added new entries to the RELEASE.md file
Added tests to cover my changes

* Remove exp tracking from feature hits and global toolbar; remove ExperimentsIcon Signed-off-by: tynandebold <thdebold@gmail.com> * Remove /experiment-tracking directory; fix tests Signed-off-by: tynandebold <thdebold@gmail.com> * Remove exp. tracking utils, reducers, styles Signed-off-by: tynandebold <thdebold@gmail.com> * Update moto requirement from ~=5.0.9 to ~=5.0.21 in /package (#2218) Updates the requirements on [moto](https://github.com/getmoto/moto) to permit the latest version. - [Release notes](https://github.com/getmoto/moto/releases) - [Changelog](https://github.com/getmoto/moto/blob/master/CHANGELOG.md) - [Commits](getmoto/moto@5.0.9...5.0.21) --- updated-dependencies: - dependency-name: moto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update httpx requirement from ~=0.27.0 to ~=0.28.0 in /package (#2216) Updates the requirements on [httpx](https://github.com/encode/httpx) to permit the latest version. - [Release notes](https://github.com/encode/httpx/releases) - [Changelog](https://github.com/encode/httpx/blob/master/CHANGELOG.md) - [Commits](encode/httpx@0.27.0...0.28.0) --- updated-dependencies: - dependency-name: httpx dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update bandit requirement from ~=1.7 to ~=1.8 in /package (#2215) Updates the requirements on [bandit](https://github.com/PyCQA/bandit) to permit the latest version. - [Release notes](https://github.com/PyCQA/bandit/releases) - [Commits](PyCQA/bandit@1.7.0...1.8.0) --- updated-dependencies: - dependency-name: bandit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update boto3 requirement from ~=1.34 to ~=1.35 in /package (#2214) Updates the requirements on [boto3](https://github.com/boto/boto3) to permit the latest version. - [Release notes](https://github.com/boto/boto3/releases) - [Commits](boto/boto3@1.34.0...1.35.71) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jitendra Gundaniya <38945204+jitu5@users.noreply.github.com> * Revert change from PR #2179 Signed-off-by: tynandebold <thdebold@gmail.com> * Remove the sanitizedPathname() function Signed-off-by: tynandebold <thdebold@gmail.com> * Remove Cypress tests for exp tracking Signed-off-by: tynandebold <thdebold@gmail.com> * Merge localStorageState state instead of the older allLocalStorageState Signed-off-by: tynandebold <thdebold@gmail.com> --------- Signed-off-by: tynandebold <thdebold@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jitendra Gundaniya <38945204+jitu5@users.noreply.github.com>

…riment-tracking Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

* remove session store Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove relateds tests Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove doc about session store Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * lint formatting Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove session store from tests Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update docs reference Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update test_server Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove sessions store from load_data Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove make_db_session_factory Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove session store from _load_data_helper Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove database.py entirely Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove test graphql folder Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove cy test related to ET tab Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * Revert changes for .md as it will be done separately Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * revert contributing.md Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove e2e test failed from ET Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> --------- Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> Co-authored-by: Huong Nguyen <huong.nguyen@mckinsey.com>

* revert back the getVersion in graphql Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update queries and schema Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fix lint error Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * revert graphql_router since it's still using in getVersion Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove experiment-tracking.py, and runs and tracking datatset from repos Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fix lint Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update format lint Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove set_database_session Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> --------- Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> Co-authored-by: Huong Nguyen <huong.nguyen@mckinsey.com>

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

* revert back the getVersion in graphql Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update queries and schema Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fix lint error Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * revert graphql_router since it's still using in getVersion Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove experiment-tracking.py, and runs and tracking datatset from repos Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fix lint Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update format lint Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove set_database_session Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove ET mentioned in the doc and readme Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove ET and session store from readme Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update new architecture diagram to remove apollo graphQL Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> --------- Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> Co-authored-by: Huong Nguyen <huong.nguyen@mckinsey.com>

rashidakanchwala · 2025-01-13T09:43:26Z

We have decided to first do a release with a Deprecation Warning for ET and then in the release after that remove ET.

Hence we can close this PR for now, and reopen it after the next release. Ofcourse, the branch is most important, so let's make sure it's there.

…riment-tracking

…m:kedro-org/kedro-viz into feature_branch/remove-experiment-tracking

* set up rest for getversion Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * include get_latest_version, is_running_outdated_version Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fixing the error Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove graphql Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * include test for getting version Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove check schema in lint Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fix lint format error Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove test for graphql Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fix syntax error Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove apollo Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update libasound2 to libasound2t64 with the lates ubutun Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update libgconf-2-4 Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update versions to version Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> --------- Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> Co-authored-by: Huong Nguyen <huong.nguyen@mckinsey.com>

astrojuanlu · 2025-02-05T11:19:21Z

This PR can now be reopened and a TSC vote requested.

…riment-tracking Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

astrojuanlu

Reviewed ARCHITECTURE, CONTRIBUTING, RELEASE, and docs/. Well done @Huongg and team!

tynandebold

Great work

merelcht

ankatiyar

ravi-kumar-pilla

Thank you 👍

Galileo-Galilei

I am not familiar enough with the code base to evaluate the code changes, but definitely fine with removing the experiment tracking functionality!

I did a final clean-up of Experiment Tracking on Kedro-viz mostly minor stuff here and there removed dataset_factory resolver implementation as it only affected Exp. Tracking also Experiment Tracking last run data was also originally showed in the flowchart metadata panel, so I removed that besides that some plotly references and other stuff. also quite a few of these files are removing experiment tracking data files from demo-project.

rashidakanchwala

Thanks @Huongg , @tynandebold and team !!!!! :)

…ew on PR Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

…m:kedro-org/kedro-viz into feature_branch/remove-experiment-tracking

Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>

tynandebold and others added 6 commits December 6, 2024 11:42

Merge remote-tracking branch 'origin' into feature_branch/remove-expe…

734f0be

…riment-tracking Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

Merge branch 'main' into feature_branch/remove-experiment-tracking

2c24441

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

Huongg requested a review from tynandebold January 13, 2025 09:39

Huongg requested review from rashidakanchwala, astrojuanlu, ravi-kumar-pilla and jitu5 as code owners January 13, 2025 09:39

Huongg closed this Jan 13, 2025

Huong Nguyen and others added 3 commits January 15, 2025 17:47

Merge remote-tracking branch 'origin' into feature_branch/remove-expe…

006e861

…riment-tracking

Merge branch 'feature_branch/remove-experiment-tracking' of github.co…

e864d76

…m:kedro-org/kedro-viz into feature_branch/remove-experiment-tracking

astrojuanlu mentioned this pull request Feb 5, 2025

Remove experiment tracking #2202

Closed

7 tasks

Huong Nguyen added 2 commits February 19, 2025 16:49

Merge remote-tracking branch 'origin' into feature_branch/remove-expe…

2f78707

…riment-tracking Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

remove deprecation banner for ET

09516b8

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

Huongg reopened this Feb 20, 2025

update release note

f16c339

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

Huongg marked this pull request as draft February 20, 2025 07:14

Huongg marked this pull request as ready for review February 20, 2025 09:36

Huongg requested a review from a team February 20, 2025 09:38

astrojuanlu approved these changes Feb 20, 2025

View reviewed changes

Huongg requested a review from a team February 20, 2025 09:57

tynandebold approved these changes Feb 20, 2025

View reviewed changes

jitu5 approved these changes Feb 20, 2025

View reviewed changes

merelcht approved these changes Feb 20, 2025

View reviewed changes

DimedS approved these changes Feb 20, 2025

View reviewed changes

ankatiyar approved these changes Feb 20, 2025

View reviewed changes

ElenaKhaustova approved these changes Feb 20, 2025

View reviewed changes

SajidAlamQB approved these changes Feb 20, 2025

View reviewed changes

ravi-kumar-pilla approved these changes Feb 20, 2025

View reviewed changes

Huongg requested a review from stephkaiser February 20, 2025 16:14

stephkaiser approved these changes Feb 20, 2025

View reviewed changes

datajoely approved these changes Feb 21, 2025

View reviewed changes

sbrugman approved these changes Feb 21, 2025

View reviewed changes

deepyaman approved these changes Feb 21, 2025

View reviewed changes

ravi-kumar-pilla mentioned this pull request Feb 22, 2025

Visualise pipeline objects in notebook #2241

Merged

5 tasks

Galileo-Galilei approved these changes Feb 22, 2025

View reviewed changes

rashidakanchwala approved these changes Feb 24, 2025

View reviewed changes

Huong Nguyen and others added 4 commits February 25, 2025 10:07

update github-pr-check to github-pr-review to avoid the max file revi…

332a4df

…ew on PR Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

Merge branch 'feature_branch/remove-experiment-tracking' of github.co…

9dcf7eb

…m:kedro-org/kedro-viz into feature_branch/remove-experiment-tracking

ignore value on mergekeeper

f708092

Signed-off-by: rashidakanchwala <rashida_kanchwala@mckinsey.com>

Fix typo in ignored CircleCI checks list

c94c2da

astrojuanlu merged commit 0abdc4e into main Feb 25, 2025
60 of 61 checks passed

astrojuanlu deleted the feature_branch/remove-experiment-tracking branch February 25, 2025 11:27

astrojuanlu mentioned this pull request Feb 25, 2025

Visualise Pipeline objects #1993

Closed

Huongg mentioned this pull request Mar 6, 2025

Release/11.0.0 #2294

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature branch/remove experiment tracking #2237

Feature branch/remove experiment tracking #2237

Huongg commented Jan 13, 2025 •

edited

Loading

rashidakanchwala commented Jan 13, 2025 •

edited

Loading

astrojuanlu commented Feb 5, 2025

astrojuanlu left a comment

tynandebold left a comment

merelcht left a comment

ankatiyar left a comment

ravi-kumar-pilla left a comment

Galileo-Galilei left a comment

rashidakanchwala left a comment

Feature branch/remove experiment tracking #2237

Feature branch/remove experiment tracking #2237

Conversation

Huongg commented Jan 13, 2025 • edited Loading

Description

QA notes:

Checklist

rashidakanchwala commented Jan 13, 2025 • edited Loading

astrojuanlu commented Feb 5, 2025

astrojuanlu left a comment

Choose a reason for hiding this comment

tynandebold left a comment

Choose a reason for hiding this comment

merelcht left a comment

Choose a reason for hiding this comment

ankatiyar left a comment

Choose a reason for hiding this comment

ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

Galileo-Galilei left a comment

Choose a reason for hiding this comment

rashidakanchwala left a comment

Choose a reason for hiding this comment

Huongg commented Jan 13, 2025 •

edited

Loading

rashidakanchwala commented Jan 13, 2025 •

edited

Loading