Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/11.0.0 #2294

Merged
merged 14 commits into from
Mar 13, 2025
Merged

Release/11.0.0 #2294

merged 14 commits into from
Mar 13, 2025

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented Mar 6, 2025

Description

Addressed #2293

Release 11.0.0

Major features and improvements

Bug fixes and other changes

Screen.Recording.2025-03-10.at.19.22.00.mov

QA notes

Please pull the changes from this PR to test it locally, or use Gitpod if there are no issues.
There should be no errors or crashes, and the app should function as expected. If possible, please test all the features listed in the release notes above.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Huong Nguyen added 3 commits March 6, 2025 15:51
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Huong Nguyen added 2 commits March 6, 2025 16:07
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
@Huongg Huongg requested a review from ravi-kumar-pilla as a code owner March 6, 2025 16:09
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
@Huongg Huongg requested a review from stephkaiser March 6, 2025 16:35
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the GraphQL-related dependencies? Maybe we should trim them before release, and also regenerate the bundle accordingly

Huong Nguyen added 2 commits March 7, 2025 14:18
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
@ravi-kumar-pilla
Copy link
Contributor

Hi @Huongg , sorry about this. I just realized I haven't updated docs regarding visualize pipeline in notebook. I will add it in some time. Can we wait for this before release. Thank you

@Huongg
Copy link
Contributor Author

Huongg commented Mar 7, 2025

Hi @Huongg , sorry about this. I just realized I haven't updated docs regarding visualize pipeline in notebook. I will add it in some time. Can we wait for this before release. Thank you

Hey @ravi-kumar-pilla yes we can wait for you to finish that. It will be great to have that so i can include the doc link in the whats' new panel and announcement to users too.

@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Mar 10, 2025

Hi, just realised during QA - the JSON preview we added to demo is no longer available. I am unsure if my cleanup PR or experiment tracking removal PR accidentally remove this - https://github.com/kedro-org/kedro-viz/pull/1930/files.
I can find some time to investigate this tomm

Huong Nguyen added 3 commits March 10, 2025 19:11
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
@rashidakanchwala
Copy link
Contributor

this is very weird. today when i went to fix this issue, it's working fine for me. I am not sure why it didn't work for me yesterday. anyways; for now since it's working will not do anything but I have a slight suspicious lazy loading of datasets is not working correctly all the time, let's keep an eye.

@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Mar 11, 2025

thanks tested in a new conda environment; everything worked fine. except that my kedro jupyter notebook command did not run the first time as I hadn't pip installed notebook. @Huongg , do you mind adding it to demo_project/requirements.in.

@ankatiyar suggested the below which was updated for spaceflights recently

ipython>=8.10
jupyterlab>=3.0
notebook
kedro[jupyter]~=0.19.11

Huong Nguyen added 2 commits March 11, 2025 11:24
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Huongg , mostly looks good to me. :) FYI, if you are using Codespaces; the updates panel might not open as we disable it in hosted version. and this is a hosted version of viz. Maybe u can refer to the video in qa.

Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Huongg ... Looks good !! Lets release 💯

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!! :shipit:

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
@Huongg Huongg merged commit 65f652b into main Mar 13, 2025
36 checks passed
@Huongg Huongg deleted the release/11.0.0 branch March 13, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants