-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore parsing hidden files on kedro viz --lite
#2271
Conversation
Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com>
kedro viz --lite
slowness
I noticed, the dataset type is now intergrations.UnavailableDataset on Kedro-Viz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
How can we verify that this effectively solves the issue? |
Hi @astrojuanlu , So the slowness might be due to many reasons but the issue's #2231 root cause is the parser parsing hidden files and gitignored files. This PR helps in resolving this issue. The test case here confirms it ignores hidden files. If the slowness is reported again, then we can check for the cause and fix it. It would be hard to predict what might cause slowness without someone reporting bugs like #2231. Wdyt ? |
Good 👍🏼
Might be wiser to tell the user to try a Code-wise I have nothing to say but also without a reproducer I can't QA this. |
kedro viz --lite
slownesskedro viz --lite
Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ravi-kumar-pilla, this looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Signed-off-by: ravi_kumar_pilla <ravi_kumar_pilla@mckinsey.com>
Description
Resolves #2231
Development notes
Warning
as discussedQA notes
Checklist
RELEASE.md
file