Fix %run_viz using old process in jupyter notebook #2267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1823
NOTE: I increased the max attempts of ports to 10 but something seems off with the entire process. So the question is should we treat each jupyter cell a separate viz instance when someone does
%run_viz
? With the current approach, the issue of using old running process is fixed but the users can run%run_viz
only 10 times in a notebook sessionDevelopment notes
_find_available_port
logic placed inrun
command to%run_viz
allocate_port
methodQA notes
Checklist
RELEASE.md
file