Add support for required keyword arguments #748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsure of what to do with the spec failing in the legacy mode on 2.1.1 :/ |
This was referenced Jun 10, 2014
|
I've taken in a more complete implementation in #785. Thanks a lot for your patch though! I haven't completely verified if there is anything in this pull request that is missing from the other, so if you want to check master and make sure everything is good that would be great, @chendo. If you find anything is missing, feel free to improve on @IvanUkhov's PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required keyword arguments were being collected under the
ParameterNode#optional_params, but was causing an error as the default argument part of the s-expr wasfalse.I've solved this by rejecting any entry that has the default set to
false, and added the params with default set tofalsetorequired_params.Specs included, and a quick test by using
@param keyword_arg: [Type] Messageappears to work correctly.