Support for named arguments of Ruby >= 2.1 #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lsegal, may I please ask for your feedback. Is there anything that should be improved? |
|
@lsegal, thank you for reviewing the code. I have taken your comments into account and updated the pull request. Please let me know if there is something that I misunderstood; I will fix it. |
lsegal
added a commit
that referenced
this pull request
Jul 14, 2014
Support for named arguments of Ruby >= 2.1
|
Thanks for the patch, sorry it took so long to pull this in! |
This was referenced Jul 14, 2014
|
Thanks for adding this @IvanUkhov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request covers Issues 728, 748, and 764.