Turning on :tables by default for RedcarpetCompat. #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
I updated the test to check for |
lsegal
added a commit
that referenced
this pull request
Apr 27, 2014
Turning on :tables by default for RedcarpetCompat.
|
Thanks for the pull request @bclennox! |
|
Thank you! |
|
@lsegal Do you know when you will be releasing a new version of the gem? We're currently referencing a commit in our Gemfile, which is not a problem, but I was curious. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lsegal This test covers the case of enabling tables in Redcarpet by default.
I should note that in Redcarpet 1.17,
:tablesis on by default, so the test initially passed without any changes.I bumped the Redcarpet version in the Gemfile to 3.1.0 (which is what we're using in our application where I was having the problem), and the test started failing. Patching
html_helper.rbgot the test passing again.So it seems to work in older and newer versions of Redcarpet. If there's anything else you think I should test or any other stylistic problems, let me know.