-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Map of Pi Repo with Changes Introduced on PCT-managed repo #13
Conversation
Merge GitHub repo code into `main` See merge request pi-network/apps/mapofpi/mapofpi!1
…fferent components
This reverts commit f16b160.
@swoocn Feel free to review, raise concerns, and/or approve/merge when you can. |
Overall, your changes LGTM, @tate1650! 👍 In the meantime, please address the minor PR comments when you have a chance, and I'll be happy to give you my full approval. |
Hey Danny, Went ahead and introduced the changes you suggested (minus the FE logger rewrites, mostly because I'm short on time). Lemme know what you think. Re: the CI/CD workflow for a local environment, that probably could be done, but feels a little like overkill to me. Ultimately you'd just need the containers running and communicating with each other on a local machine, so I think all that would really need to be done is set up the app to plug into a sandbox SDK environment (which, correct me if I'm wrong, is already done), and then expose ports via the docker-compose file so that when you're running the containers all together, they can 1. communicate with each other and 2. easily be reached from the host machine (i.e. the one connecting to sandbox.minepi.com). If you felt so inclined, I don't think you'd even need the reverse-proxy service to accomplish this. This is basically what I'm doing locally (mostly because I was having issues getting the reverse-proxy service to work at the beginning of working on this project and was looking for a method I was more familiar with in the interest of time). If this isn't very clear, or you need my help getting this setup, just lemme know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, works for me! |
Looks like we're conflict-free! Merging this one too now. |
No description provided.