-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PiCT reported bugs. #14
Conversation
Please review new changes and approve accordingly @tate1650. |
Is this WIP feature still a WIP? If so, is it in a state where it's safe to put it out onto staging without introducing more bugs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes LGTM, although I'm waiting to merge until I get confirmation that the WIP findme feature is either 1) done or 2) in a safe state to deploy to staging.
Good question, @tate1650. The WIP Findme feature is currently just an HTML dropdown element and hasn’t been completely integrated with any of our existing processes yet. You may consider it purely a visual addition, as shown in the attached screenshot, and it shouldn't introduce any new bugs. |
Ah okay, that's fine. I thought that dropdown was already present, but as long as it shouldn't cause any issues then that's fine with me. :) |
If not, will need to revisit.
[see commits]
This PR is subject to change if additional bugs are resolved before approval.