Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PiCT reported bugs. #14

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Fix PiCT reported bugs. #14

merged 4 commits into from
Oct 1, 2024

Conversation

swoocn
Copy link
Member

@swoocn swoocn commented Sep 28, 2024

  • Unable to reproduce the issue on my device, but attempted a few changes that may fix the issue for Bug Description - Can't press on set sell center for half of the mods. 🤞
    If not, will need to revisit.
  • Fixed _(PiCT) Seller Registration screen “Save” button does not respond unless a seller type is selected.
  • Set Search Center and Set Sell Center resolved and functional.
  • Introduce new Findme feature; WIP.
  • Attempt to fix staging environment issue (PiCT) Landing page search: Search stopped working.

[see commits]

This PR is subject to change if additional bugs are resolved before approval.

@swoocn swoocn requested a review from tate1650 September 28, 2024 19:28
@swoocn
Copy link
Member Author

swoocn commented Sep 28, 2024

Please review new changes and approve accordingly @tate1650.
Thanks!

@tate1650
Copy link
Collaborator

tate1650 commented Oct 1, 2024

Introduce new Findme feature; WIP.

Is this WIP feature still a WIP? If so, is it in a state where it's safe to put it out onto staging without introducing more bugs?

Copy link
Collaborator

@tate1650 tate1650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM, although I'm waiting to merge until I get confirmation that the WIP findme feature is either 1) done or 2) in a safe state to deploy to staging.

@swoocn
Copy link
Member Author

swoocn commented Oct 1, 2024

Introduce new Findme feature; WIP.

Is this WIP feature still a WIP? If so, is it in a state where it's safe to put it out onto staging without introducing more bugs?

Good question, @tate1650. The WIP Findme feature is currently just an HTML dropdown element and hasn’t been completely integrated with any of our existing processes yet. You may consider it purely a visual addition, as shown in the attached screenshot, and it shouldn't introduce any new bugs.

image

@tate1650
Copy link
Collaborator

tate1650 commented Oct 1, 2024

Ah okay, that's fine. I thought that dropdown was already present, but as long as it shouldn't cause any issues then that's fine with me. :)

@tate1650 tate1650 merged commit 04cd4c9 into dev Oct 1, 2024
@tate1650 tate1650 deleted the bug/piCT-mod-fixes branch October 1, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants