-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
I still need to update the This PR should take care of #18 (fixed in a previous PR), #34 (haven't seen any of those warnings in my tests), #47, and #56 that I'm aware. |
package.json
Outdated
"description": "Microsoft Edge Diagnostics Adapter", | ||
"main": "out/src/edgeAdapter.js", | ||
"main": "dist/edgeAdapter.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that file doesn't exist, it should it should be like it was before out/src/edgeAdapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though I reverted this changed :/
c307ed4
to
6b029f4
Compare
|
||
this._httpServer = http.createServer((req, res) => this.onServerRequest(req, res)); | ||
this._webSocketServer = new WebSocketServer({ server: this._httpServer }); | ||
this._webSocketServer.on('connection', (client) => this.onWSSConnection(client)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add a second parameter to the event handler. Something like this:
this._webSocketServer.on('connection', (client, message) => this.onWSSConnection(client, message));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed and protocol.json
updated. I'll need to manually update the release with the new files though
6b029f4
to
3840423
Compare
3840423
to
e560be0
Compare
@molant right now there is an error if you launch To make it works, you need to run first the |
@sarvaje, done! |
c56453d
to
e328cb0
Compare
e328cb0
to
3471441
Compare
Finished doing all the testing and things are working on a clean install of RS2. Merging! |
node-pre-gyp
so people in the right platform don't need to install anything (will get binaries from GitHub releases)0.6.0-unsigned
so it's clear what's happening