Implement preview on highlighting quickpick in quick search #202306

andreamah · 2024-01-12T02:59:27Z

Fixes #191259

This implements a rough version of the preview on active picker selection.

2024-01-12.10-11-40.mp4

This has:

Previewing on active selection
Restoring state on escape

TODO:

Try to get a 'true preview' editor state where we open a preview editor regardless of user settings.
Omit editor navigation from back/forward history.

cc: @TylerLeonhardt @bpasero

Fixes #191259

src/vs/workbench/contrib/search/browser/anythingQuickAccess.ts

bpasero · 2024-01-16T07:50:18Z

Saw this stack when testing:

ERR Cannot read properties of undefined (reading 'match'): TypeError: Cannot read properties of undefined (reading 'match')
    at UniqueContainer.value (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/search/browser/quickTextSearch/textSearchQuickAccess.js:69:26)
    at Emitter._deliver (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:889:26)
    at Emitter.fire (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:918:22)
    at UniqueContainer.value (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/quickInput.js:650:51)
    at Emitter._deliver (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:889:26)
    at Emitter._deliverQueue (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:900:22)
    at Emitter.fire (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:923:22)
    at UniqueContainer.value (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:98:93)
    at Emitter._deliver (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:889:26)
    at Emitter._deliverQueue (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:900:22)
    at Emitter.fire (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:923:22)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:98:93
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:1222:52
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:1235:37
    at Array.forEach (<anonymous>)
    at EventBufferer.bufferEvents (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:1235:20)
    at WorkbenchList.splice (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/list/listWidget.js:1187:32)
    at QuickInputList.setElements (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/quickInputList.js:511:23)
    at QuickPick.update (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/quickInput.js:790:30)
    at set items [as items] (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/quickInput.js:402:18)
    at applyPicks (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/pickerQuickAccess.js:89:34)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/pickerQuickAccess.js:112:52
    at applyFastAndSlowPicks (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/pickerQuickAccess.js:114:27)
    at updatePickerItems (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/pickerQuickAccess.js:178:27)
    at UniqueContainer.value (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/pickerQuickAccess.js:206:59)
    at Emitter._deliver (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:889:26)
    at Emitter._deliverQueue (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:900:22)
    at Emitter.fire (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:923:22)
    at QuickPick.doSetValue (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/quickInput.js:373:46)
    at UniqueContainer.value (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/platform/quickinput/browser/quickInput.js:558:26)
    at Emitter._deliver (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:889:26)
    at Emitter._deliverQueue (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:900:22)
    at Emitter.fire (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:923:22)
    at HistoryInputBox.onValueChange (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/inputbox/inputBox.js:354:31)
    at HTMLInputElement.<anonymous> (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/inputbox/inputBox.js:93:49)

andreamah · 2024-01-16T17:13:46Z

Fixed! ^

src/vs/workbench/contrib/search/browser/quickTextSearch/textSearchQuickAccess.ts

Fixes #191259

bpasero

I am giving +1 on a high level and defer to @TylerLeonhardt for a deeper review. I suggest to tackle follow up things such as preview mode and history blocking on demand based on further feedback.

andreamah · 2024-01-17T19:52:44Z

I can probably add options when opening the editor to omit history and force preview, then figure out how to implement them on the editor side. Does that sound like the correct way to go?

bpasero · 2024-01-17T19:57:55Z

Yeah, given preview is on by default I think we can probably ship this for stable and then gather feedback based on users and then think about the implementation side of things in Feb?

bpasero · 2024-01-17T19:59:09Z

To be fair, I am not even sure if people might expect history to work or not. If you slowly navigate over quick search results, maybe its expected that history allows you to navigate back? Thats why I am suggesting to wait for real user feedback!

andreamah · 2024-01-18T19:39:45Z

Talked to Tyler offline and he's ok with me merging for now and he'll review it after

Implement preview on highlighting quickpick in quick search

41b4581

Fixes #191259

andreamah self-assigned this Jan 12, 2024

reduce diff by only extracting editorViewState

fa466c9

andreamah marked this pull request as ready for review January 12, 2024 18:15

andreamah requested review from TylerLeonhardt and bpasero January 12, 2024 18:16

vscodenpa added this to the December / January 2024 milestone Jan 12, 2024

TylerLeonhardt reviewed Jan 13, 2024

View reviewed changes

src/vs/workbench/contrib/search/browser/anythingQuickAccess.ts Outdated Show resolved Hide resolved

move EditorViewState to src/vs/workbench/browser/quickaccess.ts

eb8e756

andreamah requested a review from TylerLeonhardt January 15, 2024 19:40

Merge branch 'main' into andreamah/issue191259

450696e

Fix item undefined error

1c09a05

bpasero reviewed Jan 16, 2024

View reviewed changes

src/vs/workbench/contrib/search/browser/quickTextSearch/textSearchQuickAccess.ts Outdated Show resolved Hide resolved

andreamah added 3 commits January 16, 2024 10:43

use item?.match

142bf28

Implement preview on highlighting quickpick in quick search

53c1e16

Fixes #191259

Implement preview on highlighting quickpick in quick search

79c82bc

Fixes #191259

andreamah requested a review from bpasero January 17, 2024 16:07

viewsservice conflict

96cc606

bpasero approved these changes Jan 17, 2024

View reviewed changes

andreamah merged commit 404f9d1 into main Jan 18, 2024

andreamah deleted the andreamah/issue191259 branch January 18, 2024 19:42

This was referenced Jan 23, 2024

Fixes #191259 Ros-Cos/Ros#1

Open

Fixes #191259 Ros-Cos/Ros#2

Open

This comment was marked as spam.

Sign in to view

Ros-Cos mentioned this pull request Jan 28, 2024

Fixes #191259 Ros-Cos/Ros#3

Open

1 task

andreamah mentioned this pull request Feb 9, 2024

Polish Quick Search Previewing #204853

Closed

andreamah mentioned this pull request Feb 20, 2024

The ability to make quick search as the default search option #204930

Closed

microsoft locked and limited conversation to collaborators Jun 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement preview on highlighting quickpick in quick search #202306

Implement preview on highlighting quickpick in quick search #202306

andreamah commented Jan 12, 2024 •

edited

Loading

bpasero commented Jan 16, 2024

andreamah commented Jan 16, 2024

bpasero left a comment •

edited

Loading

andreamah commented Jan 17, 2024

bpasero commented Jan 17, 2024

bpasero commented Jan 17, 2024 •

edited

Loading

andreamah commented Jan 18, 2024

This comment was marked as spam.

Implement preview on highlighting quickpick in quick search #202306

Implement preview on highlighting quickpick in quick search #202306

Conversation

andreamah commented Jan 12, 2024 • edited Loading

bpasero commented Jan 16, 2024

andreamah commented Jan 16, 2024

bpasero left a comment • edited Loading

Choose a reason for hiding this comment

andreamah commented Jan 17, 2024

bpasero commented Jan 17, 2024

bpasero commented Jan 17, 2024 • edited Loading

andreamah commented Jan 18, 2024

This comment was marked as spam.

andreamah commented Jan 12, 2024 •

edited

Loading

bpasero left a comment •

edited

Loading

bpasero commented Jan 17, 2024 •

edited

Loading