Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement preview on highlighting quickpick in quick search #202306

Merged
merged 9 commits into from
Jan 18, 2024
Merged

Implement preview on highlighting quickpick in quick search #202306

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
41b4581
Implement preview on highlighting quickpick in quick search
andreamah Jan 12, 2024
fa466c9
reduce diff by only extracting editorViewState
andreamah Jan 12, 2024
eb8e756
move EditorViewState to src/vs/workbench/browser/quickaccess.ts
andreamah Jan 15, 2024
450696e
Merge branch 'main' into andreamah/issue191259
bpasero Jan 16, 2024
1c09a05
Fix item undefined error
andreamah Jan 16, 2024
142bf28
use item?.match
andreamah Jan 16, 2024
53c1e16
Implement preview on highlighting quickpick in quick search
andreamah Jan 16, 2024
79c82bc
Implement preview on highlighting quickpick in quick search
andreamah Jan 17, 2024
96cc606
viewsservice conflict
andreamah Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/search/browser/quickTextSearch/textSearchQuickAccess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class TextSearchQuickAccess extends PickerQuickAccessProvider<ITextSearch
disposables.add(picker.onDidChangeActive(() => {
const [item] = picker.activeItems;

if (item.match) {
if (item && item.match) {
// only store location once, or else it will store new state every time we change active pick
if (!this.storedOriginalLocation) {
// we must remember our curret view state to be able to restore
Expand Down