testing: sort completed tests by start sequence, not completion time #235758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #235667 The root cause of the issue is the separate test run that playwright does: https://github.com/microsoft/playwright-vscode/blob/4fba0d0873ee9bf5de17219fa2f48201fd16162f/src/extension.ts#L403-L422. VS Code by default only shows failure messages from the last-ended test run, which was the original (unused) test run VS Code created, because it ends automatically after the runHandler's promise resolves. A good change to make, which happens to fix this bug, is ensuring results are retained in the order the user started the test runs versus the order in which they ended. Note that playwright is able to avoid the duplicate run since #213182, but I think this is still a sensible change to make.
Tyriar
previously approved these changes
Dec 10, 2024
Tyriar
approved these changes
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235667
The root cause of the issue is the separate test run that playwright does:
https://github.com/microsoft/playwright-vscode/blob/4fba0d0873ee9bf5de17219fa2f48201fd16162f/src/extension.ts#L403-L422.
VS Code by default only shows failure messages from the last-ended test
run, which was the original (unused) test run VS Code created, because
it ends automatically after the runHandler's promise resolves. A good
change to make, which happens to fix this bug, is ensuring results are
retained in the order the user started the test runs versus the order
in which they ended.
Note that playwright is able to avoid the duplicate run since #213182,
but I think this is still a sensible change to make.