Fix issue with ember-lodash when using Babel polyfill on Phantom. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When lodash detects that `Object.defineProperty` has been modified
by `core-js` polyfills, it intentionally exports `undefined` as its
default export (the rest of `lodash` knows how to handle this).
However, when `loader.js` detects that `exports.default === undefined`
it automatically sets `exports.default = exports` (which is mega WAT).
This causes the rest of the detection system that `lodash` has in place
around its `_defineProperty` exporting `undefined` as default to completely
fall apart. Since it expects that module to either export a function or
`undefined`, when it sees that `_defineProperty.default` is truthy it
simply invokes (what it thinks is a function). Due to the behavior of
`loader.js`, this means that we are essentially doing:
```js
let sadface = {};
sadface();
```
Which, low and behold, when ran on Phantom emits the following error:
```
Object is not a constructor (evaluating '(0, _lodash_defineProperty['default'])')
```
Thanks to @rondale-sc for helping me debug this.
|
Note, I used I wrote a blog post about this a few days ago for those that are curious: http://rwjblue.com/2017/05/09/broccoli-debugging/. |
This was referenced May 12, 2017
|
Crosslinking upstream issue in loader.js to remove this automatic default export creation: ember-cli/loader.js#114. |
|
Thank you! ❤️ |
|
Nice work 👍 |
lennyburdette
pushed a commit
to lennyburdette/loader.js
that referenced
this pull request
Jun 23, 2017
…lt` exports If a module does not define a default export, loader.js assigns `exports.default = exports` for compatibility with modules that don't use `_interopRequireDefault` from babel6. Mutating exports is unexpected behavior and causes difficult-to-diagnose [bugs][1]. We should remove `makeDefaultExport` in version 5.0. This update * adds a deprecation warning in preparation for removing `makeDefaultExport`. * adds a debug build with the deprecation enabled. Addresses ember-cli#114 [1]:mike-north/ember-lodash#104
lennyburdette
pushed a commit
to lennyburdette/loader.js
that referenced
this pull request
Jun 23, 2017
…lt` exports If a module does not define a default export, loader.js assigns `exports.default = exports` for compatibility with modules that don't use `_interopRequireDefault` from babel6. Mutating exports is unexpected behavior and causes difficult-to-diagnose [bugs][1]. We should remove `makeDefaultExport` in version 5.0. This update * adds a deprecation warning in preparation for removing `makeDefaultExport`. * adds a debug build with the deprecation enabled. Addresses ember-cli#114 [1]:mike-north/ember-lodash#104
lennyburdette
pushed a commit
to lennyburdette/loader.js
that referenced
this pull request
Jun 24, 2017
…lt` exports If a module does not define a default export, loader.js assigns `exports.default = exports` for compatibility with modules that don't use `_interopRequireDefault` from babel6. Mutating exports is unexpected behavior and causes difficult-to-diagnose [bugs][1]. We should remove `makeDefaultExport` in version 5.0. This update * adds a deprecation warning in preparation for removing `makeDefaultExport`. * adds a debug build with the deprecation enabled. Addresses ember-cli#114 [1]:mike-north/ember-lodash#104
lennyburdette
pushed a commit
to lennyburdette/loader.js
that referenced
this pull request
Jun 24, 2017
…lt` exports If a module does not define a default export, loader.js assigns `exports.default = exports` for compatibility with modules that don't use `_interopRequireDefault` from babel6. Mutating exports is unexpected behavior and causes difficult-to-diagnose [bugs][1]. We should remove `makeDefaultExport` in version 5.0. This update * adds a deprecation warning in preparation for removing `makeDefaultExport`. * adds a debug build with the deprecation enabled. Addresses ember-cli#114 [1]:mike-north/ember-lodash#104
lennyburdette
pushed a commit
to lennyburdette/loader.js
that referenced
this pull request
Aug 1, 2017
…lt` exports If a module does not define a default export, loader.js assigns `exports.default = exports` for compatibility with modules that don't use `_interopRequireDefault` from babel6. Mutating exports is unexpected behavior and causes difficult-to-diagnose [bugs][1]. We should remove `makeDefaultExport` in version 5.0. This update * adds a deprecation warning in preparation for removing `makeDefaultExport`. * adds a debug build with the deprecation enabled. Addresses ember-cli#114 [1]:mike-north/ember-lodash#104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lodash detects that
Object.definePropertyhas been modified bycore-jspolyfills, it intentionally exportsundefinedas its default export (the rest oflodashknows how to handle this).However, when
loader.jsdetects thatexports.default === undefinedit automatically setsexports.default = exports(which is mega WAT).This causes the rest of the detection system that
lodashhas in place around its_definePropertyexportingundefinedas default to completely fall apart. Since it expects that module to either export a function orundefined, when it sees that_defineProperty.defaultis truthy it simply invokes (what it thinks is a function). Due to the behavior ofloader.js, this means that we are essentially doing:Which, low and behold, when ran on Phantom emits the following error:
Thanks to @rondale-sc for helping me debug this.
Fixes #103
Fixes ember-cli/ember-cli#7001
Fixes miragejs/ember-cli-mirage#1084