-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirage acceptance tests not working with ember-cli-babel includePolyfill enabled #1084
Comments
Seems good to have an issue over here also, but I believe this the same as ember-cli/ember-cli#7001 and mike-north/ember-lodash#103. |
I'm not currently testing polyfill-dependent features so I've temporarily disabled polyfill for testing until this issue is resolved. code below: module.exports = function(defaults) {
var env = EmberApp.env();
// enable polyfill as long as we are not testing
var notTesting = env !== 'test';
var app = new EmberApp(defaults, {
'ember-cli-babel': {
includePolyfill: notTesting
}
});
... |
@bsaff I don't think that workaround is applicable in general. If you don't need the polyfill for PhantomJS, you certainly don't need it for any real browser then. Maybe this is working for you, because your tests are not touching your code that depends on the polypill? |
@simonihmig that's true. currently not testing polyfill-dependent features. I'll make a note |
Also hitting this issue. Any news on how to avoid it? |
This may be needed to get merged as well: mike-north/ember-lodash#105 |
Pretty sure this is a dupe of ember-cli/ember-cli#7001 |
* Update ember-lodash Fixes #1084 * Update npm to at least v3 in Travis
So I've got a very interesting error here. My steps:
true
.Results: A series of tests break with the following error appearing
The text was updated successfully, but these errors were encountered: