feat(polar): Intent to ship polar type #2462

cmpark0126 · 2021-12-14T10:56:08Z

Issue

Details

Implementation of the initial support of polar type
- Support rendering function and various options to draw the polar chart
- Support mouse event (it is inspired by the implementation of the pie chart)
- Add multiple test cases for the polar chart
- Add multiple demo cases for the polar chart

netil · 2021-12-15T05:14:17Z

Hi @cmpark0126, thanks for the contribution!
I looked up and found several points to be checked.

The tests are failing. All tests should be passing without any errors.
Polar's options aren't functioning properly.
When each of below option is specified, there's no changes observed.
- ploar.level.max
- ploar.padAngle
- ploar.padding
- ploar.startingAngle
- ploar.size.ratio
Missing type definition declaration for polar options
Each of polar options, should be declared in types, where is used for code assist, type checking, etc. (Ref.)
https://github.com/naver/billboard.js/tree/master/types

coveralls · 2021-12-22T01:19:24Z

Coverage decreased (-0.4%) to 89.807% when pulling 665ff3a on cmpark0126:polarChart into d3d2e05 on naver:master.

cmpark0126 · 2021-12-22T13:54:08Z

Hi @netil, thanks for the comment and sorry for the late reply.
I tried to reflect what you pointed out. Please check again.

I expect the test will be passed now.
Polar's options you mentioned above are functioning properly now. If not, please let me know again.
I tried to add type definition declaration for polar options.

If you find another problem, please comment again.
Thank you!

Co-authored-by: HanungLee <woong102345@gmail.com>

…area by using fill-opacity(#23) * feat(polar): implement mouse events feat(polar): linting feat(polar): import d3Select * feat(polar): show level line behind area Co-authored-by: Chunmyong Park <chunmyong.park@kaist.ac.kr>

* fix(polar): remove unecessary param in polar demo * feat(polar): add polar char option demo * feat(polar): add demo for polar size

* feat(polar): add doc comments * fix(polar): fix doc example code

* feat(polar): add polar_startingAngle option * docs(polar): add polar_startingAngle doc in option * docs(polar): add StartingAngle demo * feat(polar): add polar padding option * docs(polar): add doc for polar padding option * docs(polar): add demo for polar padding option * feat(polar): add polar padAngle option * docs(polar): add docs for polar padAngle option * docs(polar): add padAngle demo

* refactor(polar): create inner radius per area * fix(polar): follow linter

* test(polar): add test for polar chart * test(polar): test whether arc is rendered * test(polar): fix polar rendering test case * test(polar): set level option of polar * test(polar): check level options modified before * test(polar): set option which is hidden to show * refactor(polar): rename option * feat(polar): add polar_size_ratio option * docs(polar): add demo for polar size ratio * test(polar): add test for resize (unpassed) * skip: fix typo

* docs(polar): fix demo typo * fix(polar): function config update on polar * skip: follow lint * test(polar): add size option test * test(polar): enhance test cases

cmpark0126 · 2022-01-05T01:39:18Z

@netil How's this PR going? Do I need to fix something for this PR? Thank you!

netil · 2022-01-05T05:09:17Z

Hi @cmpark0126, due to the prior issues it is taking some time to look into.
I'll check the PR after they're done :)

netil · 2022-01-06T09:22:17Z

src/ChartInternal/shape/polar.ts

+			.padAngle(padAngle);
+
+		// remove all `g` tag from previous polar chart
+		polar.arcs.selectAll("g").data([])


IMO isn't good approach on every redraw, because removing all nodes and re appending isn't cost effective.
It should be only updating d attributes to reduce unnecessary node handling.

netil · 2022-01-06T09:28:52Z

I did looking the basic functionality and noticed during the legend toggling, the shapes aren't transitioning.
If you take on Pie's case, it behaves on toggles with transitions.
Can you fix this?

netil · 2022-03-07T09:19:58Z

After reviewing & trying fixing the issues remained, found many duplications and realized most of basic functionalities are similar with the pie type. I'm working on rewrite of polar implementation not based from this PR.

The rewrite will add minimal code necessary and most functionalities will depends from the pie, which will make reduce bundle size and the reliability which already were providing from the pie.

Implmentation of polar type Ref naver#2462

Implementation of polar type Ref naver#2462

netil · 2022-03-15T08:13:52Z

@cmpark0126 @HanungLee @Justin-Moon @sni-J
It took time to be merged. Many thanks for the contribution!

# [3.4.0-next.1](3.3.3...3.4.0-next.1) (2022-03-16) ### Bug Fixes * **axis:** Fix culling visibility on dynamic loading ([4c79daf](4c79daf)), closes [#2582](#2582) * **axis:** fix hidden axis rescale on dynamic load ([5418853](5418853)), closes [#2523](#2523) [#2571](#2571) * **util:** Check if agent has mouse ([d42adaa](d42adaa)), closes [#2550](#2550) [#2585](#2585) ### Features * **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202) * **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873) * **polar:** Intent to ship polar type ([feca715](feca715)), closes [#2462](#2462)

cmpark0126 · 2022-03-16T18:03:04Z

@netil
Sorry for the late reply. I apologize for delaying this work and thanks for the advice about this work and completing this PR.

# [3.4.0](3.3.3...3.4.0) (2022-03-31) ### Bug Fixes * **api:** Fix flow on indexed/category axis type ([4aba436](4aba436)), closes [#2595](#2595) * **axis:** Fix culling visibility on dynamic loading ([4c79daf](4c79daf)), closes [#2582](#2582) * **axis:** fix hidden axis rescale on dynamic load ([5418853](5418853)), closes [#2523](#2523) [#2571](#2571) * **generator:** Prevent possible infinite loop when tab isn't visible ([bafdb17](bafdb17)), closes [#2606](#2606) * **option:** Fix data.hide not working for bubble/scatter type ([64ae74b](64ae74b)), closes [#2609](#2609) * **util:** Check if agent has mouse ([d42adaa](d42adaa)), closes [#2550](#2550) [#2585](#2585) * **util:** Enhance parsing date string ([8d9f422](8d9f422)), closes [#1714](#1714) ### Features * **api:** Implement axis range reset ([6c9d99e](6c9d99e)), closes [#2398](#2398) * **option:** Intent to ship onclick ([63c5a53](63c5a53)), closes [#2587](#2587) * **polar:** Intent to ship polar type ([feca715](feca715)), closes [#2462](#2462)

netil added the feature label Dec 15, 2021

cmpark0126 force-pushed the polarChart branch from 9724ded to da594ad Compare December 21, 2021 04:53

cmpark0126 force-pushed the polarChart branch from 9016c1a to 2a35cac Compare December 22, 2021 12:31

Won-Joon Lee and others added 24 commits January 5, 2022 10:37

feat(polar): implement basicpolar area feature (#12)

8a8de95

feat(polar): support max size of polar chart

d911cc3

Co-authored-by: HanungLee <woong102345@gmail.com>

feat(polar): support options for polar chart level (#24)

b5da68d

Feat(polar): add demo for polar chert options (#25)

b97dab0

* fix(polar): remove unecessary param in polar demo * feat(polar): add polar char option demo * feat(polar): add demo for polar size

docs(polar): fix doc for polar chart option (#26)

e478e79

* feat(polar): add doc comments * fix(polar): fix doc example code

refactor(polar): refactor polar padding logic (#28)

8d46289

* refactor(polar): create inner radius per area * fix(polar): follow linter

refactor(polar): refactor redraw method for polar chart (#33)

5c243c9

* docs(polar): fix demo typo * fix(polar): function config update on polar * skip: follow lint * test(polar): add size option test * test(polar): enhance test cases

skip: add new demo link (#34)

9313931

skip: convert indentation to space

7510b67

test(polar): pass unpassed test cases

73f5726

feat(polar): type definition for polar options

c07fa2e

skip: follow lint

fdedda9

skip: fix typo

8a44e10

feat(polar): updating level text dynamically

a6be8b0

skip: follow lint

92fd1d0

skip: fix typo

bb48be3

skip: fix logic

3207aee

skip: follow lint

26eae0c

feat(polar): update data dynamically

1034fbb

feat(polar): update polar chart dynamically

dd77faf

skip: follow lint

22fd77d

cmpark0126 added 2 commits January 5, 2022 10:37

skip: roll-back

85b5b3f

skip: follow lint

665ff3a

cmpark0126 force-pushed the polarChart branch from 2a35cac to 665ff3a Compare January 5, 2022 01:37

netil reviewed Jan 6, 2022

View reviewed changes

netil added a commit to netil/billboard.js that referenced this pull request Mar 15, 2022

feat(polar): Intent to ship polar type

8748110

Implmentation of polar type Ref naver#2462

netil added a commit to netil/billboard.js that referenced this pull request Mar 15, 2022

feat(polar): Intent to ship polar type

a26a540

Implementation of polar type Ref naver#2462

netil mentioned this pull request Mar 15, 2022

feat(polar): Intent to ship polar type #2594

Merged

netil closed this in feca715 Mar 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(polar): Intent to ship polar type #2462

feat(polar): Intent to ship polar type #2462

cmpark0126 commented Dec 14, 2021

netil commented Dec 15, 2021

coveralls commented Dec 22, 2021 •

edited

Loading

cmpark0126 commented Dec 22, 2021 •

edited

Loading

cmpark0126 commented Jan 5, 2022

netil commented Jan 5, 2022

netil Jan 6, 2022

netil commented Jan 6, 2022

netil commented Mar 7, 2022 •

edited

Loading

netil commented Mar 15, 2022

cmpark0126 commented Mar 16, 2022

feat(polar): Intent to ship polar type #2462

feat(polar): Intent to ship polar type #2462

Conversation

cmpark0126 commented Dec 14, 2021

Issue

Details

netil commented Dec 15, 2021

coveralls commented Dec 22, 2021 • edited Loading

cmpark0126 commented Dec 22, 2021 • edited Loading

cmpark0126 commented Jan 5, 2022

netil commented Jan 5, 2022

netil Jan 6, 2022

Choose a reason for hiding this comment

netil commented Jan 6, 2022

netil commented Mar 7, 2022 • edited Loading

netil commented Mar 15, 2022

cmpark0126 commented Mar 16, 2022

coveralls commented Dec 22, 2021 •

edited

Loading

cmpark0126 commented Dec 22, 2021 •

edited

Loading

netil commented Mar 7, 2022 •

edited

Loading