Native: include DeprecatedIn hardfork into usedHardforks

[AnnaShaleva]

Description

DeprecatedIn hardfork of every native method (if not null) should be included into the set of used hardforks, otherwise no contract update will be performed during this hardfork activation:

neo/src/Neo/SmartContract/Native/NativeContract.cs

Lines 279 to 284 in 08f2dfc

	internal bool IsInitializeBlock(ProtocolSettings settings, uint index, out Hardfork[] hardforks)
	{
	var hfs = new List<Hardfork>();
	// If is in the hardfork height, add them to return array
	foreach (var hf in usedHardforks)

neo/src/Neo/SmartContract/Native/ContractManagement.cs

Lines 69 to 73 in 08f2dfc

	internal override async ContractTask OnPersistAsync(ApplicationEngine engine)
	{
	foreach (NativeContract contract in Contracts)
	{
	if (contract.IsInitializeBlock(engine.ProtocolSettings, engine.PersistingBlock.Index, out var hfs))

This commit should be a part of #3234 and a part of 3.7.4. Luckily, this new DeprecatedIn functionality is used only for the old native CryptoLib's verifyWithECDsa method with Cockatrice hardfork. And luckily, there are other CryptoLib's methods with ActiveIn set to Cockatrice hardfork. Due to these two facts this bug does not affect mainnet/testnet, and thus we don't need 3.7.5 with this fix included. So this fix may safely be postponed to 3.8.0.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[Jim8y]

I thought about this, but will there be a case where the hf only has deprecated?

[AnnaShaleva]

will there be a case where the hf only has deprecated?

There might be this case if we decide to remove some method from native contract. I think it's better to have it properly handled, just in case.