Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COVERALL: Improve maintenance and readbility of some variables #3248

Merged
merged 7 commits into from
May 23, 2024
Merged

COVERALL: Improve maintenance and readbility of some variables #3248

merged 7 commits into from
May 23, 2024

Conversation

vncoelho
Copy link
Member

No description provided.

@vncoelho vncoelho mentioned this pull request May 21, 2024
Merged
@Jim8y
Copy link
Contributor

Jim8y commented May 21, 2024

LGTM

Jim8y
Jim8y previously approved these changes May 21, 2024
View reviewed changes
@vncoelho
Copy link
Member Author

I think there is some error introduced @Jim8y

[coverlet] MergeWith: file ''/home/runner/work/neo/neo/TestResults/coverage/coverage.json'' does not exist.
   Generating report '/home/runner/work/neo/neo/tests/Neo.Plugins.Storage.Tests/'/home/runner/work/neo/neo/TestResults/coverage/'.info'

I just checked here on the report.
Let me try to fix.

@vncoelho vncoelho changed the title Improve Coverall Maintenence and Readbility and variables COVERALL: Improve maintenance and readbility of some variables May 21, 2024
@shargon
Copy link
Member

shargon commented May 21, 2024

still not working

shargon
shargon reviewed May 21, 2024
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to fix the issue instead of change the style (or both together)

@vncoelho
Copy link
Member Author

I prefer to fix the issue instead of change the style (or both together)

You can try the fix in another PR.
I still did not figure out the fix.

@Jim8y
Copy link
Contributor

Jim8y commented May 21, 2024

I think there is some error introduced @Jim8y

[coverlet] MergeWith: file ''/home/runner/work/neo/neo/TestResults/coverage/coverage.json'' does not exist.
   Generating report '/home/runner/work/neo/neo/tests/Neo.Plugins.Storage.Tests/'/home/runner/work/neo/neo/TestResults/coverage/'.info'

I just checked here on the report. Let me try to fix.

I compared the string,,,,, they are the same.... not sure whats wrong

shargon
shargon requested changes May 21, 2024
View reviewed changes
Copy link
Member

@shargon shargon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need different arguments in different calls, I think that this pr is not required, we need to solve the coverage issue first, after it, maybe this change is not required.

@vncoelho
Copy link
Member Author

vncoelho commented May 21, 2024 •
edited
Loading

maybe we need different arguments in different calls, I think that this pr is not required, we need to solve the coverage issue first, after it, maybe this change is not required.

After the fix I will test this PR again and make sure it is working.
It is surely better like this.

cschuchardt88
cschuchardt88 previously requested changes May 22, 2024
View reviewed changes
@vncoelho
Copy link
Member Author

@cschuchardt88, sure! I will try with git-env.

I will reopen after the fix.

@vncoelho vncoelho closed this May 22, 2024
@shargon shargon deleted the vncoelho-patch-1 branch May 22, 2024 10:09
@vncoelho vncoelho restored the vncoelho-patch-1 branch May 22, 2024 11:08
@vncoelho vncoelho reopened this May 22, 2024
@vncoelho vncoelho requested review from cschuchardt88 and shargon May 22, 2024 11:14
@shargon shargon merged commit c8f9338 into master May 23, 2024
6 checks passed
@shargon shargon deleted the vncoelho-patch-1 branch May 23, 2024 08:31
Jim8y added a commit to Jim8y/neo that referenced this pull request May 25, 2024
@Jim8y
Merge branch 'latest-plugins' of github.com:Jim8y/neo into latest-plu…
4a96d1e 
…gins

* 'latest-plugins' of github.com:Jim8y/neo: (21 commits)
  fix: custom plugins won't shown by command `plugins` (neo-project#3269)
  COVERALL: Improve maintenance and readbility of some variables (neo-project#3248)
  Update nuget (neo-project#3262)
  [**Part-2**] Neo module/master fixes (neo-project#3244)
  Fix `dotnet pack` error (neo-project#3266)
  Fix and Update devcontainer.json to use Dockerfile  (neo-project#3259)
  Add optimization to template (neo-project#3247)
  Optimize plugin's models (neo-project#3246)
  fix CancelTransaction !signers.Any() (neo-project#3263)
  COVERALL: fix broken by changing report from lcov to cobertura (neo-project#3252)
  fix TraverseIterator count (neo-project#3261)
  Native: include DeprecatedIn hardfork into usedHardforks (neo-project#3245)
  [**Part-1**] `neo-module/master` (neo-project#3232)
  Make `ApplicationEngine.LoadContext` protection level `public` (neo-project#3243)
  improve parse method in neo-cli (neo-project#3204)
  Fix neo-project#3239 (neo-project#3242)
  Neo.CLI: enable hardforks for NeoFS mainnet (neo-project#3240)
  v3.7.4 (neo-project#3237)
  fix hardfork issues (neo-project#3234)
  Update src/Neo.CLI/CLI/MainService.Plugins.cs
  ...

# Conflicts:
#	src/Neo.CLI/CLI/MainService.Plugins.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

@Jim8y Jim8y Jim8y approved these changes

Assignees
No one assigned
Labels
Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vncoelho @Jim8y @shargon @cschuchardt88