[PR1] Split the TestStand modules into specific modules for the nidcpower, nidigital and nidaqmx examples #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchris007
changed the title
samchris007
changed the title
keer1111
approved these changes
Oct 18, 2023
samchris007
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
dixonjoel
approved these changes
Oct 18, 2023
bkeryan
requested changes
Oct 18, 2023
bkeryan
approved these changes
Oct 19, 2023
dixonjoel
deleted the
users/sam/splitup-teststandmodules-dcpower,digital,daqmx
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Split TestStand code modules in the examples by pinmap-specific and driver-specific logic and updated the TestStand sequences accordingly.
The
nidcpower_source_dc_voltage,nidaqmx_analog_input, andnidigital_spiexamples' TestStand code modules are split into driver-specific and pin map-specific code.Note: Since we have already split the TestStand code for the
teststand_nidcpower.pyin theoutput_voltage_measurement, we have reused the same code splitting for thenidcpower_source_dc_voltage.Why should this Pull Request be merged?
Implements #392 for
nidcpower_source_dc_voltage,nidaqmx_analog_input, andnidigital_spiexamplesWhat testing has been done?