service: Make gRPC extensions public #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
dixonjoel
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Make the gRPC extension classes public:
ni_measurementlink_service.grpc.channelpool.GrpcChannelPoolni_measurementlink_service.grpc.loggers.ClientLoggerandServerLoggerThis package layout is in line with the proposal in https://dev.azure.com/ni/DevCentral/_git/ASW/pullrequest/540412, except for the fact that it is in the
ni_measurementlink_servicepackage and notni.GrpcChannelPoolis still re-exported fromni_measurementlink_service.measurement.service, and the examples still import it from this location. I would prefer to update the examples in a separate PR, after making a prerelease with this change.Why should this Pull Request be merged?
Fixes #511
What testing has been done?
Ran
poetry run pytest -v