Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service: Make gRPC extensions public #545

Merged
merged 3 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ni_measurementlink_service/_drivers/_grpcdevice.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@

import grpc

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._configuration import (
GRPC_DEVICE_SERVER_ADDRESS,
USE_GRPC_DEVICE_SERVER,
)
from ni_measurementlink_service.discovery import DiscoveryClient, ServiceLocation
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool

_logger = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion ni_measurementlink_service/_drivers/_nidaqmx.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

import nidaqmx

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._drivers._grpcdevice import (
get_insecure_grpc_device_server_channel,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.session_management._types import (
SessionInformation,
SessionInitializationBehavior,
Expand Down
2 changes: 1 addition & 1 deletion ni_measurementlink_service/_drivers/_nidcpower.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

import nidcpower

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._configuration import NIDCPOWER_OPTIONS
from ni_measurementlink_service._drivers._grpcdevice import (
get_insecure_grpc_device_server_channel,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.session_management._types import (
SessionInformation,
SessionInitializationBehavior,
Expand Down
2 changes: 1 addition & 1 deletion ni_measurementlink_service/_drivers/_nidigital.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

import nidigital

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._configuration import NIDIGITAL_OPTIONS
from ni_measurementlink_service._drivers._grpcdevice import (
get_insecure_grpc_device_server_channel,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.session_management._types import (
SessionInformation,
SessionInitializationBehavior,
Expand Down
2 changes: 1 addition & 1 deletion ni_measurementlink_service/_drivers/_nidmm.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

import nidmm

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._configuration import NIDMM_OPTIONS
from ni_measurementlink_service._drivers._grpcdevice import (
get_insecure_grpc_device_server_channel,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.session_management._types import (
SessionInformation,
SessionInitializationBehavior,
Expand Down
2 changes: 1 addition & 1 deletion ni_measurementlink_service/_drivers/_nifgen.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

import nifgen

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._configuration import NIFGEN_OPTIONS
from ni_measurementlink_service._drivers._grpcdevice import (
get_insecure_grpc_device_server_channel,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.session_management._types import (
SessionInformation,
SessionInitializationBehavior,
Expand Down
2 changes: 1 addition & 1 deletion ni_measurementlink_service/_drivers/_niscope.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

import niscope

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._configuration import NISCOPE_OPTIONS
from ni_measurementlink_service._drivers._grpcdevice import (
get_insecure_grpc_device_server_channel,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.session_management._types import (
SessionInformation,
SessionInitializationBehavior,
Expand Down
2 changes: 1 addition & 1 deletion ni_measurementlink_service/_drivers/_niswitch.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

import niswitch

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._configuration import NISWITCH_OPTIONS
from ni_measurementlink_service._drivers._grpcdevice import (
get_insecure_grpc_device_server_channel,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.session_management._types import (
SessionInformation,
SessionInitializationBehavior,
Expand Down
2 changes: 1 addition & 1 deletion ni_measurementlink_service/_internal/service_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
from ni_measurementlink_service._internal.stubs.ni.measurementlink.measurement.v2 import (
measurement_service_pb2_grpc as v2_measurement_service_pb2_grpc,
)
from ni_measurementlink_service._loggers import ServerLogger
from ni_measurementlink_service.discovery import DiscoveryClient, ServiceLocation
from ni_measurementlink_service.grpc.loggers import ServerLogger
from ni_measurementlink_service.measurement.info import MeasurementInfo, ServiceInfo

_logger = logging.getLogger(__name__)
Expand Down
2 changes: 1 addition & 1 deletion ni_measurementlink_service/discovery/_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
import grpc
from deprecation import deprecated

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._internal.stubs.ni.measurementlink.discovery.v1 import (
discovery_service_pb2,
discovery_service_pb2_grpc,
)
from ni_measurementlink_service.discovery._support import _get_discovery_service_address
from ni_measurementlink_service.discovery._types import ServiceLocation
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.measurement.info import MeasurementInfo, ServiceInfo

_logger = logging.getLogger(__name__)
Expand Down
1 change: 1 addition & 0 deletions ni_measurementlink_service/grpc/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"""gRPC extensions."""
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"""gRPC channel pool."""

from __future__ import annotations

import sys
Expand All @@ -13,7 +15,7 @@

import grpc

from ni_measurementlink_service._loggers import ClientLogger
from ni_measurementlink_service.grpc.loggers import ClientLogger

if TYPE_CHECKING:
if sys.version_info >= (3, 11):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
"""gRPC logging interceptors."""

from __future__ import annotations

import abc
Expand Down
6 changes: 3 additions & 3 deletions ni_measurementlink_service/measurement/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@
from google.protobuf.descriptor import EnumDescriptor

from ni_measurementlink_service import _datatypeinfo
from ni_measurementlink_service._channelpool import ( # re-export
GrpcChannelPool as GrpcChannelPool,
)
from ni_measurementlink_service._featuretoggles import (
SESSION_MANAGEMENT_2024Q1,
requires_feature,
Expand All @@ -41,6 +38,9 @@
)
from ni_measurementlink_service._internal.service_manager import GrpcService
from ni_measurementlink_service.discovery import DiscoveryClient, ServiceLocation
from ni_measurementlink_service.grpc.channelpool import ( # re-export
GrpcChannelPool as GrpcChannelPool,
)
from ni_measurementlink_service.measurement.info import (
DataType,
MeasurementInfo,
Expand Down
2 changes: 1 addition & 1 deletion ni_measurementlink_service/session_management/_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@

import grpc

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._internal.stubs.ni.measurementlink.sessionmanagement.v1 import (
session_management_service_pb2,
session_management_service_pb2_grpc,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.session_management._constants import (
GRPC_SERVICE_CLASS,
GRPC_SERVICE_INTERFACE_NAME,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
cast,
)

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._drivers import (
closing_session,
closing_session_with_ts_code_module_support,
Expand All @@ -42,6 +41,7 @@
session_management_service_pb2,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.session_management._constants import (
INSTRUMENT_TYPE_NI_DAQMX,
INSTRUMENT_TYPE_NI_DCPOWER,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
import pytest
from pytest_mock import MockerFixture

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._internal import grpc_servicer
from ni_measurementlink_service._internal.grpc_servicer import MeasurementServiceContext
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.measurement.service import MeasurementService
from ni_measurementlink_service.session_management import (
MultiSessionReservation,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_discovery_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import pytest
from pytest_mock import MockerFixture

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._internal.stubs.ni.measurementlink.discovery.v1.discovery_service_pb2 import (
RegisterServiceRequest,
RegisterServiceResponse,
Expand All @@ -31,6 +30,7 @@
_open_key_file,
_start_service,
)
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.measurement.info import MeasurementInfo, ServiceInfo
from tests.utilities.fake_rpc_error import FakeRpcError

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_session_management.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import pytest
from pytest_mock import MockerFixture

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._internal.stubs import session_pb2
from ni_measurementlink_service._internal.stubs.ni.measurementlink.sessionmanagement.v1 import (
session_management_service_pb2,
Expand All @@ -14,6 +13,7 @@
SessionManagementServiceStub,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool
from ni_measurementlink_service.session_management import (
MultiSessionReservation,
PinMapContext,
Expand Down
2 changes: 1 addition & 1 deletion tests/utilities/pin_map_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@

import grpc

from ni_measurementlink_service._channelpool import GrpcChannelPool
from ni_measurementlink_service._internal.stubs.ni.measurementlink.pinmap.v1 import (
pin_map_service_pb2,
pin_map_service_pb2_grpc,
)
from ni_measurementlink_service.discovery import DiscoveryClient
from ni_measurementlink_service.grpc.channelpool import GrpcChannelPool

_logger = logging.getLogger(__name__)

Expand Down