Code quality improvements to the Measurement Plug-In Client generator #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jotheeswaran-Nandagopal
requested review from
jayaseelan-james and
Avinash2Suresh
Jotheeswaran-Nandagopal
requested review from
csjall,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
jayaseelan-james
approved these changes
Sep 19, 2024
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
jayaseelan-james
requested changes
Sep 19, 2024
...es/generator/tests/utilities/measurements/non_streaming_data_measurement/_stubs/color_pb2.py
Outdated
Show resolved
Hide resolved
bkeryan
requested changes
Sep 19, 2024
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/__init__.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
...s/generator/tests/utilities/measurements/non_streaming_data_measurement/_stubs/color_pb2.pyi
Outdated
Show resolved
Hide resolved
...s/generator/tests/utilities/measurements/non_streaming_data_measurement/_stubs/color_pb2.pyi
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
packages/generator/ni_measurement_plugin_sdk_generator/client/_support.py
Outdated
Show resolved
Hide resolved
...ges/generator/tests/utilities/measurements/non_streaming_data_measurement/_stubs/color.proto
Outdated
Show resolved
Hide resolved
...ges/generator/tests/utilities/measurements/non_streaming_data_measurement/_stubs/color.proto
Outdated
Show resolved
Hide resolved
jayaseelan-james
approved these changes
Sep 20, 2024
dixonjoel
approved these changes
Sep 20, 2024
bkeryan
approved these changes
Sep 20, 2024
...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako
Outdated
Show resolved
Hide resolved
Jotheeswaran-Nandagopal
deleted the
users/jothees/client-generator-improvements
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
pin_map_contextinmakofile.__init__.pyto_support.pyin client generator.protobuf enumtonon_streaming_data_measurementfor testing.os.linesepandtab spacesfor output parameters, and handle the formatting in mako template using for loop.docstringforcreate_clientmethod.Why should this Pull Request be merged?
This Pull Request focuses on improving the overall quality and performance of the client generator code.
i.e., Protobuf enums.create_clientmethod's docstring is outdated. So, I have updated it based on the new change of moving themeasurement-service-classto option from argument.What testing has been done?