Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document about global dispatcher and errors (#3987) #4014

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

zuozp8
Copy link
Contributor

@zuozp8 zuozp8 commented Jan 19, 2025

This relates to...

errors from node:internal leak #3987

Rationale

As discussed in #3987 - errors are affected by global dispatcher

Changes

Docs about globalDispatcher being truely global
Docs about errors coming from globalDispathcer from another module

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

Signed-off-by: Konrad Baumgart <zuo.zp8@gmail.com>
@metcoder95 metcoder95 changed the title docs about global dispatcher and errors (#3987) docs: document about global dispatcher and errors (#3987) Jan 21, 2025
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Carlos Fuentes <me@metcoder.dev>
@mcollina
Copy link
Member

@metcoder95 can you approve?

@mcollina mcollina merged commit 5e234ac into nodejs:main Jan 24, 2025
30 of 31 checks passed
@github-actions github-actions bot mentioned this pull request Feb 28, 2025
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
ronag added a commit to nxtedition/undici that referenced this pull request Mar 14, 2025
* nodejs/main: (23 commits)
  Bumped v7.5.0 (nodejs#4091)
  Removed clients with unrecoverable errors from the Pool (nodejs#4088)
  feat: Allow disabling autoSelectFamily in an Agent (nodejs#4070)
  chore: update cache tests (nodejs#4027)
  fix: Fix retry-handler.js when retry-after header is a Date (nodejs#4084)
  feat: add mock call history to access request configuration in test (nodejs#4029)
  feat(docs): button to switch dark and light mode (nodejs#4044)
  Bumped v7.4.0 (nodejs#4071)
  fix: fix EnvHttpProxyAgent for the Node.js bundle (nodejs#4064)
  chore: update WPT (nodejs#4062)
  chore: update WPT (nodejs#4028)
  fix: handle missing vary header values (nodejs#4031)
  fix: do not throw unhandled exception when data is undefined in interceptor.reply (nodejs#4036)
  test: fix windows wpt (nodejs#4050)
  feat: mark `EnvHttpProxyAgent` as stable (nodejs#4049)
  don't check AbortSignal maxListeners on some node versions (nodejs#4045)
  feat(docs): copy to clipboard button (nodejs#4037)
  docs: fix incorrect method signature of `onResponseError` (nodejs#4030)
  docs: document about global dispatcher and errors (nodejs#3987) (nodejs#4014)
  chore: update WPT (nodejs#4011)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants