Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark EnvHttpProxyAgent as stable #4049

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 7, 2025

This relates to...

Rationale

Looking at the issue tracker and the file history, it looks like the implementation has been quite stable since it was introduced, so I suggest we make the docs reflect that.

Changes

Remove the "Experimental" mention in the docs.
Remove the experimental warning

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

@aduh95 aduh95 changed the title docs: mark EnvHttpProxyAgent as stable feat: mark EnvHttpProxyAgent as stable Feb 7, 2025
@metcoder95 metcoder95 requested a review from mcollina February 7, 2025 16:20
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 do you think we should make this the default in Node?

@mcollina mcollina merged commit f798628 into nodejs:main Feb 7, 2025
27 of 31 checks passed
@aduh95 aduh95 deleted the stable-EnvHttpProxyAgent branch February 8, 2025 09:33
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 8, 2025

do you think we should make this the default in Node?

I don't think I have an informed enough opinion 🤔 maybe it's something we could mention during a Collaboration Summit

@github-actions github-actions bot mentioned this pull request Feb 28, 2025
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
ronag added a commit to nxtedition/undici that referenced this pull request Mar 14, 2025
* nodejs/main: (23 commits)
  Bumped v7.5.0 (nodejs#4091)
  Removed clients with unrecoverable errors from the Pool (nodejs#4088)
  feat: Allow disabling autoSelectFamily in an Agent (nodejs#4070)
  chore: update cache tests (nodejs#4027)
  fix: Fix retry-handler.js when retry-after header is a Date (nodejs#4084)
  feat: add mock call history to access request configuration in test (nodejs#4029)
  feat(docs): button to switch dark and light mode (nodejs#4044)
  Bumped v7.4.0 (nodejs#4071)
  fix: fix EnvHttpProxyAgent for the Node.js bundle (nodejs#4064)
  chore: update WPT (nodejs#4062)
  chore: update WPT (nodejs#4028)
  fix: handle missing vary header values (nodejs#4031)
  fix: do not throw unhandled exception when data is undefined in interceptor.reply (nodejs#4036)
  test: fix windows wpt (nodejs#4050)
  feat: mark `EnvHttpProxyAgent` as stable (nodejs#4049)
  don't check AbortSignal maxListeners on some node versions (nodejs#4045)
  feat(docs): copy to clipboard button (nodejs#4037)
  docs: fix incorrect method signature of `onResponseError` (nodejs#4030)
  docs: document about global dispatcher and errors (nodejs#3987) (nodejs#4014)
  chore: update WPT (nodejs#4011)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants