Combine national downloads #796
Conversation
Merge branch 'master' into combined-national-downloads
| @@ -106,5 +106,6 @@ | |||
| </div> | |||
| </div> | |||
| </div> | |||
| </div> | |||
There was a problem hiding this comment.
Does this new closing tag have an opening <div>?
There was a problem hiding this comment.
Great. Asking because it seems you added a closing tag without adding an opening tag.
There was a problem hiding this comment.
Sure, it was missing. See the comment with the commit Missing closing div tag
There was a problem hiding this comment.
Sure, it was missing. See the comment with the commit Missing closing div tag
Aha I missed that. Good fix.
|
It is ready for testing @Robinlovelace Open this file: @nikolai-b you might have some ideas how to introduce subsections - or perhaps a divider (like a solid line to differentiate |
|
Sorry for the slow review! The <!DOCTYPE html>
<html xmlns="https://www.w3.org/1999/xhtml">and also including the navigation. I can update it if you like? |
|
No worries and thanks @nikolai-b Re missing Hope it's all fine now. |
|
When I view the page it looks like this:
Is that what you intended? Sorry there isn't an easy way for us to develop it locally yet 😢 . I've pushed it to the staging server so you can see and edit (but any merges will remove it) |
|
Is this PR still alive @nikolai-b and @usr110 ? I've converted it to a draft having seen the latest comment from Nikolai. Many thanks Ali, looks like it's an improvement overall, will be great to get this out there. |
WIP - please don't merge
Combined national download page, for the landing page. Relevant issue: #785