Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine national downloads #796

Closed
wants to merge 8 commits into from
Closed

Combine national downloads #796

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4ed0981
Add national data to nav bar
usr110 Aug 9, 2019
0888e90
Combine commute and school national data files
usr110 Aug 9, 2019
0091ac3
Missing closing div tag
usr110 Aug 9, 2019
3a229ea
Merge with master
usr110 Sep 12, 2019
9beff9d
Add H2 heading to separate commute and school national data
usr110 Sep 12, 2019
b9727e7
Replace page by section
usr110 Sep 12, 2019
7629d8a
Align div
nikolai-b Oct 1, 2019
9834170
Add doctype and html tag. Relevant comment: https://github.com/npct/p…
usr110 Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions regions_www/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,6 @@
</div>
</div>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this new closing tag have an opening <div>?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, hence I added it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Asking because it seems you added a closing tag without adding an opening tag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it was missing. See the comment with the commit Missing closing div tag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it was missing. See the comment with the commit Missing closing div tag

Aha I missed that. Good fix.

</body>
</html>
3 changes: 3 additions & 0 deletions regions_www/nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
<li style="margin-left:10px;">
<a href="/tabs/manual.html">Manual</a>
</li>
<li style="margin-left:10px;">
<a href="tabs/download_national.html">National Data</a>
</li>
<li style="margin-left:10px;">
<a href="/tabs/about.html">About</a>
</li>
Expand Down
Loading