-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCT essentials #830
PCT essentials #830
Conversation
…t_essentials, for testing
…hin the Essentials section
Looks good to me @usr110, will await reviews from @AnnaGoodman1 and @nikolai-b as requested. Great work! |
Cheers @Robinlovelace Re merge, I think it's ready. I have used a commit's SHA instead of branch name. @JDWoodcock have made the document a two pager. |
One question, probably for another day/month, but would it be worth storing the source code/text of the 'essentials' document in an easy-to-edit plain text format like .md? |
It's always easy to manage text when in plain form, so I do agree with the suggestion. We just need to think how best to keep all text at one place. Indeed something to think about for the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per my email to you, looks great but also to add/edit:
How to use the Propensity to Cycle Tool (PCT)
The material here was developed between 2016 and 2019 for use in training. To request more information or provide feedback, please email us at pct@pct.bike or report issues on our GitHub issue tracker. The PCT also has a blog, which contains further information on some of the topics featured in the case studies and FAQs. Contributions to GitHub, the blog or other parts of the project are welcome.
Thanks @AnnaGoodman1 . Have made these changes. Please see the changes here |
Looking good to me. While we're adding the essentials document is it worth adding links to other training resources? I've put in a PR #831 that adds a link to the advanced training materials delivered last year and to be delivered this year: https://htmlpreview.github.io/?https://github.com/npct/pct-shiny/blob/Robinlovelace-patch-1/regions_www/tabs/manual_body.html If @RachelAldred and others would you be happy to share the intermediate/intro training courses also I think the Essentials -> Introductory -> Intermediate -> Advanced links could provide good stepping stones for people to develop their understanding of the project, providing good links for every level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the change. Personally I'm less happy with PDFs as a format but that's just me.
👍
regions_www/index.html
Outdated
@@ -61,7 +61,7 @@ | |||
<div class="main-container"> | |||
<p> Welcome to the Propensity to Cycle Tool (PCT) for England and Wales, which provides an evidence base to inform cycling investment.</p> | |||
<p>To run the PCT, first hover over a region on the map on the left to see the regional potential, then click on the region.</p> | |||
<p>For an introduction to the tool, its use, and the scenarios, please watch the video above.</p> | |||
<p>For an introduction to the tool, its use, and the scenarios, please watch the video above and read the <a target="_blank" href="https://cdn.rawgit.com/npct/pct-shiny/30b98621b37da3cb66fcf2253583af9f026f9fce/regions_www/www/static/03d_other_reports/2020-pct-essentials.pdf">Essentials</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be a bit of a pain but I'd prefer this to be
https://npct.github.io/pct-shiny/regions_www/www/static/03d_other_reports/2020-pct-essentials.pdf
as Github pages are designed as a CDN whereas the cdn.rawgit.com
is a bit of a hack and might change.
regions_www/tabs/manual_body.html
Outdated
|
||
<div style="padding-top:6px;"> | ||
<h4><a name="essentials"></a>PCT Essentials</h4> | ||
<ul style="line-height:2.2;"> | ||
<li>Read our two pager <a target="_blank" href="https://cdn.rawgit.com/npct/pct-shiny/30b98621b37da3cb66fcf2253583af9f026f9fce/regions_www/www/static/03d_other_reports/2020-pct-essentials.pdf">Essentials</a> document first, for a high level summary</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here.
Also is this meant to be:
Read our two pager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nikolai-b
I wanted to use it but for a test I had used raw git. Now have updated the links.
Agreed, will also help build our web presence if we have a html page with all the hyperlinks on our site. Can draft a docx -> html conversion, although I'm in favour of having both pdf and html as PDFs are a nice format for sending people and printing as a two-pager. |
And @nikolai-b I guess this comment:
Means we just need to wait until it's on master before the link works (as GH-pages builds from master). I agree that is consistent and makes sense. |
and also added text for case-studies. Please view the outputs using these:
https://htmlpreview.github.io/?https://github.com/npct/pct-shiny/blob/4bfb33c1d50dc8f3f97d02fb5b4690447b3728ac/regions_www/index.html
https://htmlpreview.github.io/?https://github.com/npct/pct-shiny/blob/pct_essentials/regions_www/tabs/manual_body.html
P.S. The link to the pdf is specific to the branch - in this case,
pct_essentials
. Once we are happy with the changes, I will change it to themaster
branch. Please don't merge it without this change.