Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update production #836

Merged
merged 24 commits into from
Apr 26, 2020
Merged

Update production #836

merged 24 commits into from
Apr 26, 2020

Conversation

Robinlovelace
Copy link
Member

usr110 and others added 21 commits March 30, 2020 15:09
@usr110
Add pct-essentials as pdf
a83deab
@usr110
Add pct-essentials as a link - temporarily use the current branch, pc…
031e10c 
…t_essentials, for testing
@usr110
Make essentials as a local href
a633ee9
@usr110
Create external link to the essentials document as a bullet point wit…
42535d9 
…hin the Essentials section
@usr110
Add text for case studies
17f844d
@usr110
Add info of pct essentials on the landing page
6165687
@usr110
Reduce it to two pager
43c9ea0
@usr110
Change one to two pager
30b9862
@usr110
FIX cached document - use commit instead of branch name
2ffbc6a
@usr110
Similar to manual page, use a commit as a tag to access the pdf file
4bfb33c
@usr110
Amend heading
c4adb74
@usr110
Update training period
92342aa
@Robinlovelace
Update manual_body.html
3224d86
@usr110
Add missing closing div tag
9f23e85
@usr110
Use github pages instead of raw-git, as suggested here #830 (comment)
8fabeb4
@usr110
Merge pull request #830 from npct/pct_essentials
371d735 
PCT essentials
@nikolai-b
Remove redundant xmlns
3110c53 
This is the standard value and we had https which is invalid
@nikolai-b
Remove style tag from body
6270bfd 
Style tag is not valid in the body tag, also this CSS is not used.
@nikolai-b
Use id attributes in anchor tag
d4a5ed9 
name is deprecated
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-name
@nikolai-b
Add Advance training link
3f96fcb
@Robinlovelace
Merge pull request #834 from npct/nb-html-tidy
6ad78d9 
HTML tidy
@Robinlovelace Robinlovelace mentioned this pull request Apr 3, 2020
Open
@nikolai-b
Copy link
Contributor

@Robinlovelace I suggest we merge it now. Small incremental releases are easier to debug. That said the other changes you are suggesting are also small so in this case it doesn't matter as much. Still I'd advocate we release early, release often, it is more agile.

@Robinlovelace
Copy link
Member Author

Sounds good @nikolai-b, some of those are small and almost done - just pushed to #835 so will see if we can get these multiple small changes in by the end of the week to minimise pushes to master, although definitely agree with the principle of lots of small incremental changes being better than deploying everything in one go. All minor, little urgency, low risk so go well as one I think.

@github-pages github-pages bot temporarily deployed to github-pages April 6, 2020 20:58 Inactive
@Robinlovelace
Copy link
Member Author

The changes listed above are still worth doing. I'll open a separate issue on that.

Summary of changes:

  • Addition of the PCT Essentials document.
  • Updated links in the Manual tab

The PDF may well change soon but merging now on the basis of an Essentials document link is infinitely better than none. Sorry it's taken so long to merge, was hoping to get other changes in there.

Discussed with @nikolai-b just now.

@Robinlovelace Robinlovelace merged commit 1bbcf24 into production Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolai-b nikolai-b nikolai-b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robinlovelace @nikolai-b @usr110