Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS for /upload with header #187

Closed
mike-petrov opened this issue Mar 22, 2024 · 2 comments · Fixed by #188
Closed

CORS for /upload with header #187

mike-petrov opened this issue Mar 22, 2024 · 2 comments · Fixed by #188
Assignees
Labels
bug Something isn't working I4 No visible changes S4 Routine U0 Needs to be resolved immediately
Milestone

Comments

@mike-petrov
Copy link

Current Behavior

Request GET https://rest.fs.neo.org/v1/upload/<container_name> with data and name body without headers works, but if I want to set an attributes (it will be header: x-attribute-filepath: 123/123) it's being blocked by browser because of "CORS Missing Allow Origin":

image

related to #166, #180

Expected Behavior

Panel working fine.

Steps to Reproduce

Can be reproduced with panel.fs.neo.org if you're to upload an object

Context

panel.fs.neo.org is broken because of this.

Regression

Yes, 0.7.2 handled this fine.

Your Environment

  • Version of the product used: 0.8.2
@mike-petrov mike-petrov added bug Something isn't working U0 Needs to be resolved immediately S4 Routine I4 No visible changes labels Mar 22, 2024
@roman-khimov
Copy link
Member

We need to try Access-Control-Allow-Headers: "*", but per specification it's not compatible with authenticated requests.

@roman-khimov
Copy link
Member

The core issue here, btw, its that upload can have any X-Attribute-*. We can limit it of course to some set of standard values, but it's not the best option for this interface.

tatiana-nspcc added a commit that referenced this issue Mar 25, 2024
Closes #187.

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit that referenced this issue Mar 25, 2024
Closes #187.

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
tatiana-nspcc added a commit that referenced this issue Mar 25, 2024
Closes #187.

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
@roman-khimov roman-khimov added this to the v0.8.3 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I4 No visible changes S4 Routine U0 Needs to be resolved immediately
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants