Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handlers: Add "X-Attribute-*" header for OPTIONS upload #188

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

tatiana-nspcc
Copy link
Contributor

Closes #187.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 22.95%. Comparing base (067e507) to head (74980dc).
Report is 1 commits behind head on master.

Files Patch % Lines
handlers/preflight.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   22.95%   22.95%           
=======================================
  Files          14       14           
  Lines        3572     3572           
=======================================
  Hits          820      820           
  Misses       2631     2631           
  Partials      121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How it was tested?

@tatiana-nspcc
Copy link
Contributor Author

How it was tested?

I've locally run to check that it returns "X-Bearer-For-All-Users, X-Bearer-Lifetime, X-Bearer-Owner-Id, X-Bearer-Signature, X-Bearer-Signature-Key, Content-Type, Authorization, X-Attribute-*" in Access-Control-Allow-Headers. That's all for a while.

Closes #187.

Signed-off-by: Tatiana Nesterenko <tatiana@nspcc.io>
@roman-khimov roman-khimov merged commit 56a3746 into master Mar 25, 2024
9 of 11 checks passed
@roman-khimov roman-khimov deleted the 187-attr-cors branch March 25, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS for /upload with header
4 participants