-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include VG in Toplevel and exercices #352
Conversation
Hi, To be clear, this does not support grading image, only displaying them. @yurug what's your point of view? Should we merge only the displaying and create another PR for the grading part? |
This comment has been minimized.
This comment has been minimized.
It's strange, I don't have this issue. It works on the PopOs version of:
|
I just tried it as well. The image is properly displayed in the toplevel and the exercise still works. |
OK, @EmileRolley I don't know where it can come from... @hferee thanks! It's an old PR I've opened, but now it has been refactored, it might be mature for merging (as long as we ensure it works). |
@maiste I have made minor comments. |
Co-authored-by: Yann Régis Gianas <yann@regis-gianas.org>
Okey, after some |
@EmileRolley @maiste Anything more? Can I merge? |
It's ok for me. |
The CI seems to stuck on Mac, whereas it wasn't the case before I apply the path. Is it possible to manually run it again? @yurug, good for merging to me. |
Thanks! |
Hi,
this is a PR to partially fix #237.
Content of the PR:
Vg.image
in the toplevel` with pretty_printing.