[CCI] Add bluebird replaces for plugins/vis_type_tagcloud

[Nicksqain]

Description

Issues Resolved

• closes Eliminate Bluebird in favor of native async functionality #3662

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Merging #4028 (698f208) into main (b04e657) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4028   +/-   ##
=======================================
  Coverage   66.43%   66.43%           
=======================================
  Files        3229     3229           
  Lines       62069    62069           
  Branches     9599     9599           
=======================================
  Hits        41234    41234           
  Misses      18531    18531           
  Partials     2304     2304           

Flag	Coverage Δ
Linux	66.38% <ø> (+<0.01%)	⬆️
Windows	66.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[manasvinibs]

@Nicksqain Can you add the missing changelog entry to the PR?

[Nicksqain]

@Nicksqain Can you add the missing changelog entry to the PR?

Yes, of course.
I was waiting for an answer on how best to create a changelog for the current issue

[manasvinibs]

@Nicksqain Can you add the missing changelog entry to the PR?

Yes, of course. I was waiting for an answer on how best to create a changelog for the current issue

I would say Maintenance or Refactoring is the best place to add changelog entry for this change.

[Nicksqain]

I would say Maintenance or Refactoring is the best place to add changelog entry for this change.

Yes, thank you. I did, I added it to refactoring.
But I asked on the issue page if I needed to add an entry for each PR, or skip changelog

[manasvinibs]

I would say Maintenance or Refactoring is the best place to add changelog entry for this change.

Yes, thank you. I did, I added it to refactoring. But I asked on the issue page if I needed to add an entry for each PR, or skip changelog

I would suggest change log for a PR is a good strategy as long as single PR solves one problem at a time or same problem within the scope of logical separated component. If your PR's are spread across to fix single issue of concern which is in this case I think, it's reasonable to include a changelog in one of the PR's as opposed to changelog in each PR as the primary intention of having changelog here is for the release tracker.
If this PR cleans all the usages of Bluebird modules in vis_type_tagcloud plugin, then it can have a changelog for plugin specific refactoring I think.

[manasvinibs]

Are there any benefit in using setImmediate() over setTimeout()here?

[Nicksqain]

I don't think there will be any difference in performance in this case.
setTimeout() has the same priority as delay from bluebird.
setImmediate() can be executed earlier, which can cause errors

[ananzh]

As @AMoo-Miki suggested in ur other PR, this delay is used many times. We should move to a single place to avoid the redundance.

[AMoo-Miki]

Since this piece is used so many times, I would recommend you pull it out into a function of its own; something like:

const waitForRenderCompletion = async (tagCloud) => 
  new Promise((resolve) => {
    tagCloud.once('renderComplete', resolve);
  });

[ananzh]

+1 to both put this func out and use
tagCloud.once('renderComplete', resolve)); cuz (() => { resolve(); }) doesn't add anything in terms of functionality; it just calls resolve with no arguments.

[ananzh]

As @AMoo-Miki suggested in ur other PR, this delay is used many times. We should move to a single place to avoid the redundance.

[ananzh]

+1 to both put this func out and use
tagCloud.once('renderComplete', resolve)); cuz (() => { resolve(); }) doesn't add anything in terms of functionality; it just calls resolve with no arguments.

[abbyhu2000]

Convert to draft for now, can be marked as ready again when the requested changes are resolved.

[ananzh]

@Nicksqain Due to an extended period without updates, we're going to close this issue for now. We appreciate your contribution and understand that priorities and availability can change. Please feel free to reopen this issue when you have the opportunity to revisit it. Thank you for your understanding.