Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate the discover:newExpereince #9511

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

angle943
Copy link
Collaborator

Description

  • We are deprecating the discover:newExperience setting and DataGrid table for 3.0.
  • Note that this newExperience does not exist in the queryEnhanced view.

Screenshot

These are the things going away for 3.0:

  • We are first deprecating the option to toggle the legacy discover experience:
Screenshot 2025-03-10 at 10 17 05 AM
  • And we are deprecating the "new" discover table:
Screenshot 2025-03-10 at 10 17 48 AM

Changelog

  • deprecate: discover:newExpereince and DataGridTable

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Justin Kim <jungkm@amazon.com>
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.74%. Comparing base (2a9cb94) to head (4958dd0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9511      +/-   ##
==========================================
- Coverage   61.76%   61.74%   -0.03%     
==========================================
  Files        3815     3815              
  Lines       91890    91890              
  Branches    14570    14570              
==========================================
- Hits        56758    56736      -22     
- Misses      31474    31542      +68     
+ Partials     3658     3612      -46     
Flag Coverage Δ
Linux_1 28.98% <ø> (ø)
Linux_2 ?
Linux_3 39.30% <ø> (+<0.01%) ⬆️
Linux_4 28.86% <ø> (ø)
Windows_1 28.99% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 39.30% <ø> (ø)
Windows_4 28.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@angle943 angle943 merged commit d967693 into opensearch-project:main Mar 10, 2025
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 10, 2025
* deprecate the discover:newExpereince

Signed-off-by: Justin Kim <jungkm@amazon.com>

* Changeset file for PR #9511 created/updated

---------

Signed-off-by: Justin Kim <jungkm@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit d967693)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
angle943 pushed a commit that referenced this pull request Mar 11, 2025
* deprecate the discover:newExpereince



* Changeset file for PR #9511 created/updated

---------



(cherry picked from commit d967693)

Signed-off-by: Justin Kim <jungkm@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@angle943 angle943 deleted the deprecate-new-discover branch March 12, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants