Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Remove the "newExperience" table option in Discover #9531

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

angle943
Copy link
Collaborator

Description

  • This is a followup of deprecate the discover:newExpereince #9511 and we are removing the deprecated parts for 3.0.
  • I realized that some parts that I have marked as "deprecated" cannot actually be deprecated, so I have kept them in.

Issues Resolved

Changelog

  • breaking: Remove the deprecated "newExperience" table option in discover

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Justin Kim <jungkm@amazon.com>
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.84%. Comparing base (29f05d7) to head (28c3f27).

❗ There is a different number of reports uploaded between BASE (29f05d7) and HEAD (28c3f27). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (29f05d7) HEAD (28c3f27)
Windows_2 1 0
Linux_1 1 0
Windows_4 1 0
Windows_1 1 0
Windows_3 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9531       +/-   ##
===========================================
- Coverage   61.82%   44.84%   -16.98%     
===========================================
  Files        3825     2637     -1188     
  Lines       92040    64151    -27889     
  Branches    14598    10461     -4137     
===========================================
- Hits        56902    28769    -28133     
- Misses      31464    33693     +2229     
+ Partials     3674     1689     -1985     
Flag Coverage Δ
Linux_1 ?
Linux_2 56.38% <ø> (ø)
Linux_4 28.91% <ø> (+0.06%) ⬆️
Windows_1 ?
Windows_2 ?
Windows_3 ?
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@angle943 angle943 marked this pull request as draft March 12, 2025 17:43
Signed-off-by: Justin Kim <jungkm@amazon.com>
Signed-off-by: Justin Kim <jungkm@amazon.com>
Signed-off-by: Justin Kim <jungkm@amazon.com>
Signed-off-by: Justin Kim <jungkm@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant