-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi-category filtering of results #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
reviewed
Oct 29, 2021
ylwu-amzn
reviewed
Oct 29, 2021
ylwu-amzn
reviewed
Oct 29, 2021
amitgalitz
reviewed
Oct 29, 2021
ylwu-amzn
reviewed
Oct 29, 2021
amitgalitz
reviewed
Nov 1, 2021
amitgalitz
reviewed
Nov 1, 2021
amitgalitz
reviewed
Nov 1, 2021
ylwu-amzn
previously approved these changes
Nov 1, 2021
amitgalitz
previously approved these changes
Nov 1, 2021
…only fetch summaries if non-sample
…ayout in new charts sub-filter
…omaly filtering in child charts
…e chart when applicable
9068421
to
677651f
Compare
ylwu-amzn
approved these changes
Nov 1, 2021
ohltyler
added a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Nov 8, 2021
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
1 task
ohltyler
added a commit
that referenced
this pull request
Nov 9, 2021
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for filtering results on a subset of categorical fields. For example, if a user has 2 categorical fields selected, they can now search for the top values of one field, ignoring the other. And, when selecting a value of one of these fields, a sorted list of the top values of the other field is displayed for viewing on the anomaly and feature charts. This is supported for both real-time and historical scenarios.
The primary changes in this PR include:
AnomalyHistory
), making them more stateless as components should be.Entities: <entity-value-1>, <entity-value-2>
=>Entities: <entity-name-1>: <entity-value1>, <entity-name-2>: <entity-value-2>
. The main reason for this change is so the full entity information can be passed to the child components when needed - before, only the values were being passed.Testing:
Screenshots:
New combo box filter for categorical fields:

New combo box filter for child categorical field values (when a heatmap cell is selected):

Multi-time-series support, with consistent coloring for anomaly & feature results:

Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.