Fix bug of missing annotations on feature charts #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lyHistory container Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
commented
Nov 10, 2021
Comment on lines
-146
to
-156
| const getFeatureAnnotations = () => { | ||
| if (isEmpty(props.annotations)) { | ||
| return []; | ||
| } | ||
| return filterWithDateRange( | ||
| props.annotations, | ||
| props.dateRange, | ||
| 'coordinates.x0' | ||
| ); | ||
| }; | ||
|
|
There was a problem hiding this comment.
not needed anymore, since all filtering is done prior to being passed to this component, which should be stateless.
ylwu-amzn
approved these changes
Nov 10, 2021
amitgalitz
approved these changes
Nov 10, 2021
kaituo
approved these changes
Nov 10, 2021
ohltyler
added a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Nov 10, 2021
ohltyler
added a commit
to ohltyler/anomaly-detection-dashboards-plugin-1
that referenced
this pull request
Nov 10, 2021
ohltyler
added a commit
that referenced
this pull request
Nov 10, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
added a commit
that referenced
this pull request
Nov 10, 2021
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Ohlsen ohltyler@amazon.com
Description
When the feature charts are rendered as a child component in the
AnomalyHistorycontainer, the annotations aren't formatted properly. This is due to one missed place where the annotations weren't converted into 2D arrays, where they should have been as part of #107. The proper conversion is already done when the feature chart is rendered as a child ofAnomaliesChartcontainer (see here). Additionally, theFeatureChartwasn't handling the new 2D representation of annotations, so that is fixed as well. Added some clarification comments above that change.The side effect of this bug is that the annotations were always being passed as an empty array, so no annotations were showing up for the charts.
Confirmed the code changes now show proper annotations for all scenarios:
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.