Updating 2.x from 2.7 changes #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-project#329) (opensearch-project#358) Signed-off-by: Eric Wei <menwe@amazon.com> (cherry picked from commit 19f29e1) Co-authored-by: Eric Wei <menwe@amazon.com>
…arch-project#341) (opensearch-project#353) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com>
opensearch-project#384) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 23e09e5) Co-authored-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
…search-project#388) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 1ecd7ea) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit a6c1ebc) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
…ensearch-project#393) * notebooks fix for cypress and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 3219f14)
…project#397) * Update traces cypress tests Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update traces cypress test Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix traces cypress tests Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix filters test Signed-off-by: Rupal Mahajan <maharup@amazon.com> --------- Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit b8f9ca3) Co-authored-by: Rupal Mahajan <maharup@amazon.com>
…arch-project#399) (opensearch-project#403) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 05ef180) Co-authored-by: Joshua Li <joshuali925@gmail.com>
) (opensearch-project#402) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 6309e63) Co-authored-by: Joshua Li <joshuali925@gmail.com>
…opensearch-project#405) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 3d74bac) Co-authored-by: Joshua Li <joshuali925@gmail.com>
…#401) (opensearch-project#404) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 78347d9) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
…nsearch-project#408) * fix saving multiple metrics to SOpanels Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused variable Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit a4cb6d1) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
* Fix Panel View (legacy) - Duplicate - Rename - Delete --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
* Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> (cherry picked from commit 969e639) Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
) (opensearch-project#421) * [Dashboard listing] update edit url and view url Update to include BASE_URL if basePath is defined. Since create url is just a direct nav and needs the basePath when passing props to the provider, the source code no longer appends the basePath to keep these URLs consistent. A feature should consolidate the basePaths in the dashboard listing service so that createUrl also adds the base path. At which point we no longer need the base path. Also removed some rogue URLs. Core PR: opensearch-project/OpenSearch-Dashboards#3922 --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit f94c21e) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
…ct#420) * fix for SOpanels editMode Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * rename edit button data-test-subj Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
* Fixes * Panel View (legacy) - Duplicate - Rename Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> * Toasts use hook from useOpenSearchDashboards context provider Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> * Testing for CustomPanel Toast Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> * update catches from comments, minor code cleaning Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused redux slice Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * revert cypress changes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add toasts to SOflyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix messaging for multiple delete Signed-off-by: Derek Ho <dxho@amazon.com> * fix up toast and error handling for create and delete flows Signed-off-by: Derek Ho <dxho@amazon.com> * fix up clone Signed-off-by: Derek Ho <dxho@amazon.com> * fix rename in table Signed-off-by: Derek Ho <dxho@amazon.com> * fix rename in custom panel so view Signed-off-by: Derek Ho <dxho@amazon.com> * fix up panel toasts Signed-off-by: Derek Ho <dxho@amazon.com> * fix up for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * code cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * finish merge Signed-off-by: Derek Ho <dxho@amazon.com> * fix up PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com>
…roject#436) * change samples to saved object * add sample to so * fix saved object sample * fix up * add back toast * revert file * refactoring * use constant --------- (cherry picked from commit ce06ccb) Signed-off-by: Derek Ho <dxho@amazon.com>
* Add check for existing panel name Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Nit Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Remove double await Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add rename name check test Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Remove test Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add unique id to sample panel name Signed-off-by: Rupal Mahajan <maharup@amazon.com> --------- Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
…t#450) * change custom panels -> observability dashboards Signed-off-by: Eric Wei <menwe@amazon.com> * rest of the panel renaming Signed-off-by: Eric Wei <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit a4a310e)
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
|
DCO fails due to author email id being not correct and co-author naming issue, we can ignore these |
joshuali925
approved these changes
May 24, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #482 +/- ##
======================================
Coverage ? 42.83%
======================================
Files ? 299
Lines ? 17795
Branches ? 4357
======================================
Hits ? 7623
Misses ? 10131
Partials ? 41
Flags with carried forward coverage won't be shown. Click here to find out more. |
kavithacm
approved these changes
May 24, 2023
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
* Fix for hover issue on docs of discover/explorer data grid (opensearch-project#329) (opensearch-project#358) Signed-off-by: Eric Wei <menwe@amazon.com> (cherry picked from commit 19f29e1) Co-authored-by: Eric Wei <menwe@amazon.com> * [2.7] Refactor Saved objects and add visualization embeddable (opensearch-project#341) (opensearch-project#353) Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Eric Wei <menwe@amazon.com> * Cohesion main to 2.7 (opensearch-project#382) Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> * Fix redirection to legacy event_analytics URL (opensearch-project#383) (opensearch-project#384) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 23e09e5) Co-authored-by: Joshua Li <joshuali925@gmail.com> * [2.7] Redo pick from main to 2.7 (opensearch-project#385) Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> * Metrics analytics support for SOpanels (opensearch-project#386) (opensearch-project#388) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 1ecd7ea) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> * change plugin ordering (opensearch-project#389) (opensearch-project#390) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit a6c1ebc) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> * notebooks fix for cypress and minor bugs (opensearch-project#392) (opensearch-project#393) * notebooks fix for cypress and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove comments Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 3219f14) * Update traces integration tests (opensearch-project#391) (opensearch-project#397) * Update traces cypress tests Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Update traces cypress test Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix traces cypress tests Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Fix filters test Signed-off-by: Rupal Mahajan <maharup@amazon.com> --------- Signed-off-by: Rupal Mahajan <maharup@amazon.com> (cherry picked from commit b8f9ca3) Co-authored-by: Rupal Mahajan <maharup@amazon.com> * Fix redirection to legacy event_analytics URL from dashboards (opensearch-project#399) (opensearch-project#403) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 05ef180) Co-authored-by: Joshua Li <joshuali925@gmail.com> * Adjust metrics top menu layout to avoid overflow (opensearch-project#398) (opensearch-project#402) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 6309e63) Co-authored-by: Joshua Li <joshuali925@gmail.com> * Support duplicate visualization in dashboard (opensearch-project#400) (opensearch-project#405) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 3d74bac) Co-authored-by: Joshua Li <joshuali925@gmail.com> * fix panel visualization preview, new viz workflow (opensearch-project#401) (opensearch-project#404) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 78347d9) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> * Fix saving multiple metrics to SOpanels (opensearch-project#407) (opensearch-project#408) * fix saving multiple metrics to SOpanels Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused variable Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit a4cb6d1) Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> * Panel table fixes (opensearch-project#406) * Fix Panel View (legacy) - Duplicate - Rename - Delete --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> * Release Notes 2.7.0.0 (opensearch-project#394) (opensearch-project#412) * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> * Release Notes 2.7.0.0 Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> (cherry picked from commit 969e639) Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * [Dashboard listing] update edit url and view url (opensearch-project#416) (opensearch-project#421) * [Dashboard listing] update edit url and view url Update to include BASE_URL if basePath is defined. Since create url is just a direct nav and needs the basePath when passing props to the provider, the source code no longer appends the basePath to keep these URLs consistent. A feature should consolidate the basePaths in the dashboard listing service so that createUrl also adds the base path. At which point we no longer need the base path. Also removed some rogue URLs. Core PR: opensearch-project/OpenSearch-Dashboards#3922 --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit f94c21e) Co-authored-by: Kawika Avilla <kavilla414@gmail.com> * Fix invalid time range in new panels (opensearch-project#419) Signed-off-by: Joshua Li <joshuali925@gmail.com> * open new tab for editing panel visualization (opensearch-project#430) Signed-off-by: Eric Wei <menwe@amazon.com> * Save new prometheus metrics to OSD saved objects (opensearch-project#428) * Save new prometheus metrics to OSD saved objects Signed-off-by: Joshua Li <joshuali925@gmail.com> * Return if failed at saving metrics Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * fixes edit mode callback bug in Saved Object Panels (opensearch-project#420) * fix for SOpanels editMode Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * rename edit button data-test-subj Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Add Toasts to Observability Dashboards (opensearch-project#435) * Fixes * Panel View (legacy) - Duplicate - Rename Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> * Toasts use hook from useOpenSearchDashboards context provider Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> * Testing for CustomPanel Toast Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> * update catches from comments, minor code cleaning Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused redux slice Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * revert cypress changes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add toasts to SOflyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix messaging for multiple delete Signed-off-by: Derek Ho <dxho@amazon.com> * fix up toast and error handling for create and delete flows Signed-off-by: Derek Ho <dxho@amazon.com> * fix up clone Signed-off-by: Derek Ho <dxho@amazon.com> * fix rename in table Signed-off-by: Derek Ho <dxho@amazon.com> * fix rename in custom panel so view Signed-off-by: Derek Ho <dxho@amazon.com> * fix up panel toasts Signed-off-by: Derek Ho <dxho@amazon.com> * fix up for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * code cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * finish merge Signed-off-by: Derek Ho <dxho@amazon.com> * fix up PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> * change samples to saved object (opensearch-project#427) (opensearch-project#436) * change samples to saved object * add sample to so * fix saved object sample * fix up * add back toast * revert file * refactoring * use constant --------- (cherry picked from commit ce06ccb) Signed-off-by: Derek Ho <dxho@amazon.com> * Add Error handling on duplicate dashboard names (opensearch-project#441) * Add check for existing panel name Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Nit Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Remove double await Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add rename name check test Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Remove test Signed-off-by: Rupal Mahajan <maharup@amazon.com> * Add unique id to sample panel name Signed-off-by: Rupal Mahajan <maharup@amazon.com> --------- Signed-off-by: Rupal Mahajan <maharup@amazon.com> * fix timestamp overriding issue (opensearch-project#449) Signed-off-by: Eric Wei <menwe@amazon.com> * Renaming custom panels to Observability Dashboards (opensearch-project#450) * change custom panels -> observability dashboards Signed-off-by: Eric Wei <menwe@amazon.com> * rest of the panel renaming Signed-off-by: Eric Wei <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com> * Fix delete failure when no osd item selected (opensearch-project#452) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit a4a310e) * Open log patterns by default (opensearch-project#444) (opensearch-project#459) Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 72970aa) * diff merging between 2.x and 2.7 Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add service fields length check in app analytics Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Derek Ho <dxho@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 776d1ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating 2.x from 2.7 changes
Issues Resolved
#477
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.