Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"License text modified" overlaps with license name on smaller screens #2529

Closed
mstykow opened this issue Jan 25, 2024 · 0 comments · Fixed by #2603
Closed

"License text modified" overlaps with license name on smaller screens #2529

mstykow opened this issue Jan 25, 2024 · 0 comments · Fixed by #2603
Assignees
@mstykow
Labels
bug Something isn't working

Comments

@mstykow
Copy link
Member

mstykow commented Jan 25, 2024

Describe the bug
On smaller screens, the "license text modified" label overlaps with the actual license name.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Audit View
  2. Modify the license text
  3. Reduce screen size until overlap occurs

Expected behavior
Either move the label out of the input field in general, or find a way to start hiding it as the screen shrinks.
@mstykow mstykow added the bug Something isn't working label Jan 25, 2024
mstykow added a commit that referenced this issue Jan 25, 2024
@mstykow
fix: "license text modified" overlaps license text
a9cb3ad 
- replace end adornment label by end adornment icon in order to save space

closes #2529

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
@mstykow mstykow mentioned this issue Jan 25, 2024
Closed
@mstykow mstykow self-assigned this Jan 25, 2024
mstykow added a commit that referenced this issue Mar 13, 2024
@mstykow
fix: license text modified overlaps license name
Loading
Loading status checks…
a85861c 
- always show license text input if license text exists
- show button with explanatory tooltip to specify a custom license text when no license text present
- this button enables user to specify a license text when needed but hides the input in most cases

closes #2529

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
@mstykow mstykow mentioned this issue Mar 13, 2024
Merged
mstykow added a commit that referenced this issue Mar 14, 2024
@mstykow
fix: license text modified overlaps license name
Loading
Loading status checks…
5d0fe83 
- always show license text input if license text exists
- show button with explanatory tooltip to specify a custom license text when no license text present
- this button enables user to specify a license text when needed but hides the input in most cases

closes #2529

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow added a commit that referenced this issue Mar 15, 2024
@mstykow
fix: license text modified overlaps license name
Loading
Loading status checks…
133c4dc 
- always show license text input if license text exists
- show button with explanatory tooltip to specify a custom license text when no license text present
- this button enables user to specify a license text when needed but hides the input in most cases

closes #2529

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow added a commit that referenced this issue Mar 20, 2024
@mstykow
fix: license text modified overlaps license name
Loading
Loading status checks…
a1fbb82 
- always show license text input if license text exists
- show button with explanatory tooltip to specify a custom license text when no license text present
- this button enables user to specify a license text when needed but hides the input in most cases

closes #2529

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow added a commit that referenced this issue Mar 21, 2024
@mstykow
fix: license text modified overlaps license name
Loading
Loading status checks…
4609ba9 
- always show license text input
- display default license text as placeholder when a default license name is selected

closes #2529

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstykow mstykow

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@mstykow