fix: license text modified overlaps license name #2603
Conversation
|
I like the approach. I am just wondering if it might be more convenient to who an option to expand the license text instead of showing it whenever it is present? I have the feeling that the small text field might be too small for longer texts. |
I guess the same argument could be made for copyright and comment? |
mstykow
force-pushed
the
fix-license-text-overlap
branch
from
a85861c to
5d0fe83
Compare
I've changed the maxRows for license to 10 again. |
mstykow
force-pushed
the
fix-license-text-overlap
branch
2 times, most recently
from
133c4dc to
a1fbb82
Compare
src/shared/text.ts
Outdated
| licenseText: 'License Text', | ||
| useCustomLicenseText: 'Use custom license text', | ||
| useCustomLicenseTextHint: | ||
| 'Specify a custom license text if your license does not match one of the common licenses from the list above.', |
There was a problem hiding this comment.
I am not sure I entirely understand the tooltip. Is the license text input filled automatically if I select a common license? I thought not?
There was a problem hiding this comment.
And I agree, as we discussed before, I might make sense to drop the expandable approach entirely and just always show the field.
There was a problem hiding this comment.
tried an approach where we always show the license text input now.
mstykow
force-pushed
the
fix-license-text-overlap
branch
from
7e01cc2 to
a1fbb82
Compare
- always show license text input - display default license text as placeholder when a default license name is selected closes #2529 Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow
force-pushed
the
fix-license-text-overlap
branch
from
a1fbb82 to
4609ba9
Compare
There was a problem hiding this comment.
I think that is a good solution. We might need to communicate that the palceholder is something that shows the real license text, that is associated with the attribution, instead of some "real" placeholder that won't affect the output file. But I think that is okay.
Summary of changes
Context and reason for change
closes #2529
How can the changes be tested
Check out the license text field when