Unit test linking and unlinking attributions #2039
Merged
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| }); | ||
|
|
||
| it('correctly maintains childrenFromAttributedResources', () => { |
There was a problem hiding this comment.
Does this item test anything which is not covered by the previous one? It seems that the only difference between the two is that the first one contains more expect statements.
There was a problem hiding this comment.
good point. now that im looking at it, theres really no need to have two tests for linking or for unlinking. and i should revert my changes to the deletion test, since i only made it match the first test.
Signed-off-by: Markus Obendrauf <markusobendrauf@fb.com>
MarkusObendrauf
force-pushed
the
test-link-unlink
branch
from
1180f16 to
e931939
Compare
davidmundelius
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Unit test linking and unlinking resources.
Also, improve the test for deleting resources, which currently doesn't assert any changes between the output and input
childrenFromAttributedResources.Context and reason for change
I plan to change these functions soon as part of #2030, so having unit tests is nice.
How can the changes be tested
yarn jest src/Frontend/state/helpers/__tests__/save-action-helpers.test.ts