fix: discard-and-proceed not working when creating new attribution #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adjust check setting the selected attribution to distinguish between null and empty string Fixes #2635 Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow
force-pushed
the
fix-discard-and-proceed
branch
from
72618af to
a69da7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
Fixes #2635
How can the changes be tested
Make a change to an attribution and try to create a new attribution. Notice that discard-and-proceed then works as expected and shows an empty attribution.