Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensure notices generated do have content #2765

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Hellgartner
Copy link
Contributor

Summary of changes

Add a check in the build step to ensure that the notice document is not empty

Context and reason for change

There was a bug where we delivered an empty notices document
#2760

This shall prevent a repetition of the bug

Alternative Solutions considered:

  • Write a playwright based e2e test: Did not fly as playwright does not manage to follow the "jump" from electron to the real browser after clicking the notice menu link.
  • Writing jest unit test would have required translating the tooling to typescript (jest support for mjs -- or to be exact the used include statements -- is currently only experimental) which was determined to be out of scope for this ticket

How can the changes be tested

Break the notice generation (e.g. by modifying generateNotices.mjs) and observe yarn build (or yarn generate-notice) to fail.

Note: Please review the guidelines for contributing to this repository.

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@abraemer abraemer merged commit d649d54 into main Feb 10, 2025
5 checks passed
@abraemer abraemer deleted the bug/notice_generation_broken_add_e2e_test branch February 10, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants