test: ensure notices generated do have content #2765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add a check in the build step to ensure that the notice document is not empty
Context and reason for change
There was a bug where we delivered an empty notices document
#2760
This shall prevent a repetition of the bug
Alternative Solutions considered:
How can the changes be tested
Break the notice generation (e.g. by modifying
generateNotices.mjs
) and observeyarn build
(oryarn generate-notice
) to fail.Note: Please review the guidelines for contributing to this repository.