Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagefilter: make short output format as unstable #1173

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Jan 28, 2025

This commit changes the "short" output format so that it is marked as "unstable". There are some open questions about this format and how it relates to e.g.
osbuild/osbuild-composer#4336 which adds very similar API is a slightly different format.

So to prevent users from relying on the API before that is resolved we need to at least make them aware that this may still change.

This commit changes the "short" output format so that it is
marked as "unstable". There are some open questions about this
format and how it relates to e.g.
osbuild/osbuild-composer#4336
which adds very similar API is a slightly different format.

So to prevent users from relying on the API before that is resolved
we need to at least make them aware that this may still change.
@mvo5 mvo5 requested a review from a team as a code owner January 28, 2025 14:08
schuellerf
schuellerf previously approved these changes Jan 28, 2025
Copy link
Contributor

@schuellerf schuellerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect remediation, THANKS!

@mvo5
Copy link
Contributor Author

mvo5 commented Jan 28, 2025

Sorry, I'm a muppet, I pushed the wrong commit here accidentally (was meant for #1175), please re-approve.

@mvo5 mvo5 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into osbuild:main with commit 822c081 Jan 28, 2025
33 checks passed
@mvo5 mvo5 deleted the mark-filteresult-short-format-as-unstable branch January 28, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants