imagefilter: use distrosort to sort the distro names
#1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
filter-distro-sort
branch
from
4c35828 to
6445e02
Compare
achilleas-k
previously approved these changes
Jan 28, 2025
supakeen
previously approved these changes
Jan 28, 2025
This commit uses the `distrosort` package to sort the distro names by their name/version. This means that the output of centos is sorted by low to high version like this: ```console $ ./image-builder list-images --output=short --filter distro:centos* centos-9: ami: [ aarch64, x86_64 ] ... centos-10: ami: [ aarch64, x86_64 ] ... ``` with the regular "string" search this was: ```console $ ./image-builder list-images --output=short --filter distro:centos* centos-10: ami: [ aarch64, x86_64 ] ... centos-9: ami: [ aarch64, x86_64 ] ... ``` (this is also quite visible with rhel).
mvo5
force-pushed
the
filter-distro-sort
branch
from
6445e02 to
3c74aea
Compare
|
Sorry, conflicts, had to force push (which is a bit silly because there were actually none) |
supakeen
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[build on top of https://github.com//pull/1173]
This commit uses the
distrosortpackage to sort the distro namesby their name/version. This means that the output of centos is sorted
by low to high version like this:
with the regular "string" search this was:
(this is also quite visible with rhel).