Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(allocator): add Vec2 #9646

Merged
merged 1 commit into from
Mar 12, 2025
Merged

feat(allocator): add Vec2 #9646

merged 1 commit into from
Mar 12, 2025

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 10, 2025

related: #9706

These two files are copied from Bumplo's vec and raw_vec, they will be used to replace allocator_api2's Vec later PRs.

Copy link
Member Author

Dunqing commented Mar 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Mar 10, 2025
Copy link

codspeed-hq bot commented Mar 10, 2025

CodSpeed Performance Report

Merging #9646 will not alter performance

Comparing 03-10-feat_allocator_add_vec2 (3d4400c) with main (f9580d8)

Summary

✅ 32 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[checker.ts] N/A 3 s N/A

Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked these 2 files are copied completely verbatim from bumpalo. Only differences are the addition of comments at top of files saying where the code was copied from, and running rustfmt on them.

Merging just this one for now. Would like to look into why lifetime changes are required in #9656 before merging the rest of the stack.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
Copy link
Contributor

overlookmotel commented Mar 12, 2025

Merge activity

  • Mar 12, 4:52 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 12, 4:52 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 12, 4:57 AM EDT: A user merged this pull request with the Graphite merge queue.

related: #9706

These two files are copied from Bumplo's `vec` and `raw_vec`, they will be used to replace allocator_api2's `Vec` later PRs.
@graphite-app graphite-app bot force-pushed the 03-10-feat_allocator_add_vec2 branch from 7d8ee88 to 3d4400c Compare March 12, 2025 08:52
@graphite-app graphite-app bot merged commit 3d4400c into main Mar 12, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 03-10-feat_allocator_add_vec2 branch March 12, 2025 08:57
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants