Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(allocator): connect Vec2 module and make it compile #9647

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 10, 2025

This PR aims to connect the Vec2 with the whole program and make it compile and pass the CI. Since the diff is hard to understand, we may need to read the commit one by one to understand the changes.

Copy link
Member Author

Dunqing commented Mar 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Mar 10, 2025
Copy link

codspeed-hq bot commented Mar 10, 2025

CodSpeed Performance Report

Merging #9647 will not alter performance

Comparing 03-10-feat_allocator_add_vec2_module_and_make_it_compile (415d24f) with main (3d4400c)

Summary

✅ 33 untouched benchmarks

@Dunqing Dunqing changed the title feat(allocator): add Vec2 module and make it compile feat(allocator): connect Vec2 module and make it compile Mar 10, 2025
@Dunqing Dunqing force-pushed the 03-10-feat_allocator_add_vec2_module_and_make_it_compile branch 3 times, most recently from c5a40c0 to 9580d1e Compare March 10, 2025 15:54
@Dunqing Dunqing force-pushed the 03-10-feat_allocator_add_vec2 branch from f328de5 to 7d8ee88 Compare March 11, 2025 10:26
@Dunqing Dunqing force-pushed the 03-10-feat_allocator_add_vec2_module_and_make_it_compile branch from 9580d1e to 642f881 Compare March 11, 2025 10:26
@Dunqing Dunqing marked this pull request as ready for review March 11, 2025 10:31
@overlookmotel overlookmotel changed the base branch from 03-10-feat_allocator_add_vec2 to graphite-base/9647 March 12, 2025 08:52
@overlookmotel overlookmotel force-pushed the 03-10-feat_allocator_add_vec2_module_and_make_it_compile branch from 642f881 to d9a6cb3 Compare March 12, 2025 08:57
@overlookmotel overlookmotel changed the base branch from graphite-base/9647 to main March 12, 2025 08:58
@overlookmotel overlookmotel force-pushed the 03-10-feat_allocator_add_vec2_module_and_make_it_compile branch from d9a6cb3 to 415d24f Compare March 12, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants