fix(ast): change ImportExpression::attributes to options

[Boshen]

To align with ts-eslint

https://github.com/typescript-eslint/typescript-eslint/blob/9aa0b6b49807599b1c2b704b778df74c91084a7c/packages/ast-spec/src/expression/ImportExpression/spec.ts#L23

[Boshen]

• fix(ast): change ImportExpression::attributes to options #9665 👈 (View in Graphite)
• fix(ast): align TSImportType field names with ts-eslint #9664
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Boshen]

@overlookmotel simply changing this field breaks raw_transfer, am I missing something?

[tasks/ast_tools/src/generators/raw_transfer.rs:772:9] field_name = "arguments"

thread '<unnamed>' panicked at tasks/ast_tools/src/generators/raw_transfer.rs:773:87:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[codspeed-hq]

CodSpeed Performance Report

Merging #9665 will not alter performance

_{Comparing 03-11-fix_ast_change_importexpression_attributes_to_options_ (475b48f) with main (a7b6b60)}

Summary

✅ 33 untouched benchmarks

[overlookmotel]

@overlookmotel simply changing this field breaks raw_transfer, am I missing something?

Sorry. Not a very helpful error message!

Usually, just changing the field name is enough. But where there's a custom serializer (#[estree(via = Converter)]), you have to implement serialization/deserialization twice - once in Rust in ESTree impl on the "converter" type, and second time in JS in the #[estree(raw_deser = "...")] attribute on that same type. The fragment of JS in raw_deser attr gets inserted into the JS-side deserializer code.

This is the commit that fixes it: 2c4af1b

The syntax of the raw_deser code is pretty dreadful and is going to be largely incomprehensible to anyone but me. I'll try to improve it.

[Boshen]

Merge activity

• Mar 11, 6:22 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 11, 6:22 AM EDT: A user added this pull request to the Graphite merge queue.
• Mar 11, 11:08 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
• Mar 11, 8:09 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 11, 8:09 PM EDT: A user added this pull request to the Graphite merge queue.
• Mar 11, 8:16 PM EDT: A user merged this pull request with the Graphite merge queue.