fix(ast/estree): fix TSImportType

[hi-ogawa]

• Closes ast: serialize TSImportType.options as ObjectExpression #9663

[hi-ogawa]

• fix(ast/estree): fix TSImportType #9670 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[hi-ogawa]

Ah, I just realized this is being handled in #9665 😅 Closing

[hi-ogawa]

Or maybe I misunderstood the PR #9664 🤔 Will it be still required to do special serialization for TSImportType.options as per the issue? @Boshen

[codspeed-hq]

CodSpeed Performance Report

Merging #9670 will not alter performance

_{Comparing 03-11-fix_ast_estree_fix_tsimporttype (f05e966) with main (89b6e4c)}

Summary

✅ 39 untouched benchmarks

[overlookmotel]

I'm also not clear on if this is needed or not. But, if it is needed, I think you could put #[estree(via = ...)] on just the elements field of TSImportAttributes, rather than on the whole type. Handle the other differences with #[estree(rename = "ObjectExpression")] on the type, and #[estree(rename = "properties")] on the field.

Unfortunately we can't avoid custom serializers/deserializers for these kind of cases, but in my view the smaller we can keep them, the better. It's easy for the Rust and JS implementations to get out of sync, and at some point soon we'll also add support for transferring ASTs in the other direction (JS -> Rust), at which point we'll also need to add (1) a JS serializer and (2) a Rust deserializer for all these custom cases. Inevitably it's going to get a bit messy, but it's ideal to minimize that mess as much as we can.

PS: Hope you're enjoying the bizarre torture of writing the raw_deser impls! I will try to improve that. I only got as far as the bare minimum to make it work. Definitely needs improvement.

[ArnaudBarre]

Can this be omitted from the typegen? (with TSImportAttributeName)